Opened 8 years ago

Closed 6 years ago

#11882 closed defect (fixed)

[patch][cla] dojox.image.ThumbnailPicker makes connections twice

Reported by: jer Owned by: dylan
Priority: high Milestone: 1.9
Component: Dojox Version: 1.5
Keywords: ThumbnailPicker connect twice Cc:
Blocked By: Blocking:

Description

lines

		this.connect(this.navPrev, "onclick", "_prev");
		this.connect(this.navNext, "onclick", "_next");

must be in postCreate() not in init() cause when setDataStore() called, init() called again and makes double connection

Attachments (1)

thumbnail.patch (1.7 KB) - added by bill 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Adam Peller

Milestone: 1.5.1tbd
Owner: changed from Adam Peller to dante

comment:2 Changed 8 years ago by dante

Milestone: tbd1.7
Owner: changed from dante to Shane O'Sullivan

ping.

comment:3 Changed 8 years ago by mpasternak

+1

comment:4 Changed 8 years ago by Chris Mitchell

Priority: highnormal

reducing priority to normal, this is not on the hot list for 1.7 rc1

comment:5 Changed 7 years ago by bill

I looked at this quickly to see if I could take it off the books, but it's badly broken. Most or all of the code in init() should only be run once. Presumably that's why the function is called init(). And there's a this.isInitialized flag to prevent that code from running twice. So the real problems are perhaps:

  • the comment for the init() method doesn't match what it does.
  • the reset() method sets this.isInitialized back to false, without disconnecting the event handlers.

Also, I tested against dojox/image/tests/test_ThumbnailPicker.html, pressing the "change datastore" button, but I didn't see a difference in behavior when moving those lines to postCreate(). In either case the scroll right button goes to far but the scroll left button is OK.

Changed 7 years ago by bill

Attachment: thumbnail.patch added

comment:6 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

comment:7 Changed 6 years ago by dylan

Milestone: 2.01.9
Owner: changed from Shane O'Sullivan to dylan
Status: newassigned
Summary: dojox.image.ThumbnailPicker makes connections twice[patch][cla] dojox.image.ThumbnailPicker makes connections twice

Reviewed and tested Bill's patch. While it would be nice to update this entire module to AMD, I will apply Bill's patch now to fix obviously broken behavior.

comment:8 Changed 6 years ago by dylan

Resolution: fixed
Status: assignedclosed

In [30832]:

fixes #11882, double connect issue in dojox.image.ThumbnailPicker?

Note: See TracTickets for help on using tickets.