Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11875 closed defect (fixed)

Couldn't built standard build.

Reported by: Seldarly Owned by: Rawld Gill
Priority: high Milestone: 1.6
Component: BuildSystem Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

Getting error:

error loading uri: ./../../release/dojo/dojo/_base.js, exception: Error: Could not load 'dojo._base.lang'; last tried '../../release/dojo/dojo/_base/lang.js'

Attachments (2)

p11875-1 (490 bytes) - added by Rawld Gill 9 years ago.
build.log (5.0 KB) - added by youngho 9 years ago.
standard profile failed log

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by bill

Owner: changed from James Burke to Rawld Gill

I'm guessing this is from Rawld's checkin. It started happening recently, right?

Changed 9 years ago by Rawld Gill

Attachment: p11875-1 added

comment:2 Changed 9 years ago by Rawld Gill

Error in /util/buildscripts/jslib/fileUtil.js consequent to global change of "require.def" to "define". Repaired in patch p11875-1 attached.

(I'll check this in as soon as my svn permissions are sorted out).

comment:3 Changed 9 years ago by youngho

I patched p11875-1 in my local copy and base profile built sucessfully. But standard profile failed !.

Please refer to the attached log file.

Changed 9 years ago by youngho

Attachment: build.log added

standard profile failed log

comment:4 Changed 9 years ago by Rawld Gill

Status: newassigned

The modifications made to the build system to process AMD modules are quite brittle since the v1.x build system is not intended to be used with AMD modules (new build system(s) will repair this shortcoming). In particular, AMD modules submitted to the v1.x build system must:

  1. Make the define call on the first line of the file.
  2. Express the define call and all of its arguments on a single line.
  3. Close the file with the sequence });

For example:

define("mySpace/myModule", ["dojo", "anotherSpace/mod1", "yetAnotherSpace/mod1"], function(dojo) {

//module code goes here

});

This seemingly equivalent code will cause the build system to choke:

define("mySpace/myModule", 
  ["dojo", "anotherSpace/mod1", "yetAnotherSpace/mod1"], 
  function(dojo) {

//module code goes here

});

comment:5 Changed 9 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

comment:6 Changed 9 years ago by bill

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.