Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11857 closed defect (fixed)

[regression] Declaration widget broken in IE

Reported by: haysmark Owned by: bill
Priority: high Milestone: 1.5.1
Component: Dijit Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

See:

http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/test_Declaration.html

In both IE6 and IE8, the parser seems to get tripped up on the ProgressBar widgets nested in the Declaration widgets.

Change History (5)

comment:1 Changed 9 years ago by bill

Description: modified (diff)
Milestone: tbd1.6
Owner: set to bill
Status: newassigned

Thanks, you are right. Declaration sets _noScript:true in it's prototype to avoid parsing nested <script type="dojo/..."> tags, but it also needs to set stopParser:true to avoid looking for nested widgets.

comment:2 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [23013]) Parser shouldn't descend into a dijit.Declaration to look for nested widgets. Fixes #11857 !strict.

comment:3 Changed 9 years ago by bill

(In [23014]) Parser shouldn't descend into a dijit.Declaration to look for nested widgets. Fixes #11857 on 1.5 branch !strict.

comment:4 Changed 9 years ago by bill

Milestone: 1.61.5.1
Summary: Declaration widget broken in IE[regression] Declaration widget broken in IE

I think this was fallout from the parser refactor to run top down, rather than using dojo.query(). Fixed now, thanks for the heads-up.

comment:5 Changed 8 years ago by bill

In [26322]:

Removing code that's no longer necessary after the stopParser:true flag added in [23013]. (Also note that the code was only looking for dojoType, not data-dojo-type.). Refs #11857.

Note: See TracTickets for help on using tickets.