Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11856 closed defect (fixed)

Regexp in editor LinkDialog plugin requires file after domain before URI

Reported by: valqk Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.6
Component: Editor Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

In the LinkDialog?.js in editor plugins, on line 35 the regex requires url like:
http://example.org/index.php?page=home
and won't allow url like:
http://example.org/?page=home
which is also a valid one.

This is the fixed regex urlRegExp

the change is here:
*(?:[^?#\\s/]{0,}(?:\\?[^?#\\s/]*)?(?:#.*)?)?)?"

which was:
*(?:[^?#\\s/]+(?:\\?[^?#\\s/]*)?(?:#.*)?)?)?"

correct me if I'm wrong pls.

Change History (4)

comment:1 Changed 9 years ago by Adam Peller

Component: GeneralEditor
Milestone: 1.5.1tbd
Owner: anonymous deleted

comment:2 Changed 9 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz

comment:3 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [23017]) Minor fix in regexp to allow urls without a page, but with query params. fixes #11856

comment:4 Changed 9 years ago by Jared Jurkiewicz

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.