Opened 9 years ago

Closed 9 years ago

#11853 closed defect (fixed)

Build profile using optimize="closure" fails, references missing Java class

Reported by: James Thomas Owned by: James Burke
Priority: high Milestone: 1.6
Component: BuildTools Version: 1.5
Keywords: closure build Cc: james.thomas@…
Blocked By: Blocking:

Description

I've been testing the Dojo build system using Google Closure's compiler.

Including the optimize="closure" directive in any profile produces the same error, when the buildUtil.optimizeJS function is called for each module file. A sample is shown below...

release: Optimizing (closure) file: ../../release/dojo/dijit/_DialogMixin.js release: Could not strip comments for file: ../../release/dojo/dijit/_DialogMixin.js, error: TypeError?: Cannot call property value in object com.google.common.flags.Flag?. It is not a function, it is "object".

The "com.google.common.flags.Flag" class doesn't seem to exist looking at the latest javadocs for the Closure compiler (http://closure-compiler.googlecode.com/svn/trunk/javadoc/index.html).

I've included a small patch to solve this problem and have tested this against local profiles.

Attachments (1)

buildUtil.js.patch (1.2 KB) - added by James Thomas 9 years ago.
Patch to fix Closure support in buildUtil.js

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by James Thomas

Attachment: buildUtil.js.patch added

Patch to fix Closure support in buildUtil.js

comment:1 Changed 9 years ago by James Burke

Milestone: tbd1.6

comment:2 Changed 9 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [23003]) Fixes #11853, properties changed in latest Closure Compiler, thanks to James Thomas.

Note: See TracTickets for help on using tickets.