Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11837 closed defect (fixed)

PersevereStore.getStores should use dojox.json.ref.toJson in generated schema methods

Reported by: Remoun Metyas Owned by: Kris Zyp
Priority: high Milestone: 1.6
Component: DojoX Data Version: 1.5
Keywords: PeresevereStore Cc:
Blocked By: Blocking:

Description

PersevereStore.getStores adds static and instance methods to the schema and prototype of the returned stores, respectively. However, these methods use dojo.toJson to serialize the arguments, which breaks when using objects returned by that same store as arguments (usually a "too much recursion" error)!

dojox.json.ref is already dojo.require'd, so the fix is a one-line patch (attached).

Attachments (1)

json.ref.patch​ (446 bytes) - added by Remoun Metyas 10 years ago.
Patch for dojox/data/PersevereStore.js

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Remoun Metyas

Attachment: json.ref.patch​ added

Patch for dojox/data/PersevereStore.js

comment:1 Changed 10 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to Kris Zyp

comment:2 Changed 10 years ago by Remoun Metyas

I've signed the CLA (Remoun Metyas).

comment:3 Changed 10 years ago by Kris Zyp

Resolution: → fixed
Status: new → closed

(In [23786]) Use dojox.json.ref.toJson for getStores, fixes #11837

comment:4 Changed 10 years ago by bill

Milestone: tbd → 1.6

bulk update: bugs fixed in past few months, presumably milestone is 1.6

Note: See TracTickets for help on using tickets.