[patch][cla] Form widgets interfere with dijit.Menu

[avoidscorn]

Tested on Firefox 3.6.10/Linux and Chromium 6.0.472.62/Linux.

If you bind a dijit.Menu to a form widget and then right-click on the form widget, the form widget will steal focus from the menu popup and close it as soon as you mouse-up.

The culprit is dijit._FormWidget._onMouseDown, which attempts to restore focus to the form widget even if the user mouse-ups somewhere else. This works fine unless the focus was on a popup that just opened.

The attach test case patch adds a form widget to test_Menu.js.

I'm attaching two possible fixes:

1. ignoreRightClick.patch: dijit._FormWidget ignores right clicks for focus-grabbing purposes. This will not fix the issue for leftClickToOpen=true menus. However those menus don't work for form widgets anyway, because form widgets almost always capture left clicks, so it's a moot point.
2. detectPopup.patch: dijit._FormWidget checks to see if a popup opened before it tries to grab focus. In theory, this will work for leftClickToOpen=true menus.

Another alternative is to make dijit.Menu try and stop mousedown/mouseup events from being detected by the form widget, but that seems risky.

[avoidscorn]

test_Menu.html patch

[avoidscorn]

_FormWidget.js patch to ignore right clicks

[avoidscorn]

_FormWidget.js patch to detect popups

[avoidscorn]

Oops, dijit._FormWidget should be dijit.form._FormWidget.

[bill]

ignoreRightClick.patch seems safe, except dojo.mouseButtons.isLeft() is the portable way to test mouse buttons. (You didn't say you tested your patch on IE, I bet it doesn't work there.) You just need to add a section to Menu_mouse.html (the robot test) to automate the test you added to test_Menu.html.

I looked up the reason for the whole _onMouseDown() handler. It's from #5434 and also #6888, although it no longer seems to be necessary for getting buttons on Chrome to focus when mouseup happens outside the button. But it is still necessary for ValidationTextBox widgets to get focus when the user clicks the right section, where the validation icon is.

[avoidscorn]

Uses dojo.mouseButtons.isLeft to detect left-clicks

[avoidscorn]

tests/robot/Menu_mouse.html patch

[avoidscorn]

Display "dijit.form._FormWidget" instead of "dijit._FormWidget"

[avoidscorn]

I believe the new patches address your concerns.

[Douglas Hays]

avoidscorn, do you have a signed CLA on file with Dojo?

[avoidscorn]

Yes, I have a CLA on file.

[Douglas Hays]

(In [23303]) Fixes #11836. Patch from avoidscorn (CLA). _FormWidget onMouseDown now only consumes a left mousedown. Added automated contextmenu test.