Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#1183 closed defect (fixed)

FloatingPane Maximize correction

Reported by: andrei.neculau@… Owned by: bill
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

When you maximize the FloatingPane? (at least when it is a child of the BODY tag), scrollbars appear due to overflow (shadow).

Therefore, in FloatingPane?.js, maximizeWindow function: this.previous = { ... overflowParent: this.domNode.parentNode.style.overflow }

and also add a line this.domNode.parentNode.style.overflow = "hidden";

Then, in restoreWindow function: if (this.windowState=="minimized") { this.show() } else { ... this.domNode.parentNode.style.overflow = this.previous.overflowParent; }

....

Change History (3)

comment:1 Changed 13 years ago by andrei.neculau@…

I would like to add a SVN diff, in order to make this easier:

Index: D:/xhosts/dentab.ro.my/www/js/dojo_nightly/src/widget/FloatingPane.js
===================================================================
--- D:/xhosts/dentab.ro.my/www/js/dojo_nightly/src/widget/FloatingPane.js	(revision 5011)
+++ D:/xhosts/dentab.ro.my/www/js/dojo_nightly/src/widget/FloatingPane.js	(working copy)
@@ -143,6 +143,10 @@
 				bottom: this.domNode.style.bottom,
 				right: this.domNode.style.right
 			};
+			
+			this.previousParentOverflow = this.domNode.parentNode.style.overflow;
+			this.domNode.parentNode.style.overflow = "hidden";
+
 			this.domNode.style.left =
 				dojo.html.getPixelValue(this.domNode.parentNode, "padding-left", true) + "px";
 			this.domNode.style.top =
@@ -173,6 +177,8 @@
 				for(var attr in this.previous){
 					this.domNode.style[attr] = this.previous[attr];
 				}
+				this.domNode.parentNode.style.overflow = this.previousParentOverflow;
+
 				this.resizeTo(this.previous.width, this.previous.height);
 				this.previous=null;
 	

comment:2 Changed 13 years ago by andrei.neculau@…

Resolution: fixed
Status: newclosed

comment:3 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.