Opened 9 years ago

Closed 4 years ago

#11826 closed defect (patchwelcome)

problem removing file when multiple files have same name

Reported by: mkantor Owned by:
Priority: high Milestone: 1.13
Component: DojoX Uploader Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

I can only remove a file by specifying filename. Here's the problem:

If I'm not uploading the files immediately, then I can select a few files from one folder, and a few from another. Its quite possible (in fact, for some filenames like index.html fairly common) for a filename to appear multiple times. There is no way for me to specify WHICH index.html I want to remove.

SUGGESTION: In my local environment I tried assigning a unique id to every file; made this a part of each entry in my local copy of dijit.FileUploader?.fileList. I can reliably remove a file from the filelist via this automatically assigned unique id... if I'm using the html uploader. But for the flash uploader I can't do this unless the flash uploader supports deletion by id rather than by name. My advice is that fileList incorporates an automatically generated integer id for each file to uniquely identify it, and to have a removeFileById method that allows developers to remove by id rather than the more limiting (but friendlier) removal by name.

Change History (8)

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from Adam Peller to Mike Wilcox

comment:2 Changed 9 years ago by Mike Wilcox

Milestone: tbd1.5.1

Efforts are moved to dojox.form.Uploader, but I believe this problem may still persist. Plan enhancements for 1.6 and I will investigate.

comment:3 Changed 9 years ago by dante

Milestone: 1.5.11.7

comment:4 Changed 7 years ago by bill

Component: DojoxDojoX Uploader
Summary: dijit.FileUploaderproblem removing file when multiple files have same name

comment:5 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

comment:6 Changed 4 years ago by dylan

Owner: changed from Mike Wilcox to dylan
Status: newassigned

comment:7 Changed 4 years ago by dylan

Milestone: 2.01.12
Owner: dylan deleted
Status: assignedopen

comment:8 Changed 4 years ago by dylan

Resolution: patchwelcome
Status: openclosed

Given the lack of attention that dojox/form/Uploader has received, I'm closing this ticket as patchwelcome. If you would like to work on a fix, please create a pull request and reopen the ticket.

Note: See TracTickets for help on using tickets.