Opened 9 years ago
Closed 6 years ago
#11795 closed enhancement (invalid)
[patch] [cla] Enhancement suggestion for ThumbNailPicker
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | high | Milestone: | 1.9 |
| Component: | Dojox | Version: | 1.5 |
| Keywords: | ThumbnailPicker | Cc: | chof@… |
| Blocked By: | Blocking: |
Description
For one of my own projects I have enhanced the ThumbnailPicker? with the following new functionalities:
- added new subscription topics navigate, loading and loaded to increase the possibilities for page controllers to interact with the script
- fixed bug #11785 to overcome urgend development problems
- extended the behaviour of the isVisilbe() method to return true even if only parts of the image are visible
(see the patch against the trunk, detailed change notes and a test case for the new functionality in the attachments)
Attachments (4)
Change History (10)
Changed 9 years ago by
| Attachment: | ThumbnailPicker_Enhancements_11795.diff added |
|---|
Changed 9 years ago by
| Attachment: | test_ThumbnailPicker_Extensions_CHO.html added |
|---|
Test case to show the new functionality of the enhancements
comment:1 follow-up: 2 Changed 9 years ago by
| Component: | General → Dojox |
|---|---|
| Owner: | changed from anonymous to Shane O'Sullivan |
Hi, have you filed a CLA (dojofoundation.org/cla)?
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
| Summary: | Enhancement suggestion for ThumbNailPicker → [patch] [cla] Enhancement suggestion for ThumbNailPicker |
|---|
comment:4 Changed 6 years ago by
| Milestone: | tbd → 1.9 |
|---|---|
| Owner: | changed from Shane O'Sullivan to dylan |
| Status: | new → assigned |
Adopting this one. Will update to AMD and then try to get this into trunk for 1.9.
comment:5 Changed 6 years ago by
| Owner: | changed from dylan to chof@… |
|---|---|
| Status: | assigned → pending |
Before I start updating this to AMD, I wanted to land your patch.
Can you please verify the attached patch, and then I'll do my best to update to AMD before 1.9?
comment:6 Changed 6 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Patch for ThumbnailPicker? Enhancements