Opened 9 years ago

Closed 7 years ago

#11795 closed enhancement (invalid)

[patch] [cla] Enhancement suggestion for ThumbNailPicker

Reported by: chof@… Owned by: chof@…
Priority: high Milestone: 1.9
Component: Dojox Version: 1.5
Keywords: ThumbnailPicker Cc: chof@…
Blocked By: Blocking:

Description

For one of my own projects I have enhanced the ThumbnailPicker? with the following new functionalities:

  • added new subscription topics navigate, loading and loaded to increase the possibilities for page controllers to interact with the script
  • fixed bug #11785 to overcome urgend development problems
  • extended the behaviour of the isVisilbe() method to return true even if only parts of the image are visible

(see the patch against the trunk, detailed change notes and a test case for the new functionality in the attachments)

Attachments (4)

ThumbnailPicker_Enhancements_11795.diff (2.3 KB) - added by chof@… 9 years ago.
Patch for ThumbnailPicker? Enhancements
test_ThumbnailPicker_Extensions_CHO.html (5.9 KB) - added by chof@… 9 years ago.
Test case to show the new functionality of the enhancements
changelog.txt (1.8 KB) - added by chof@… 9 years ago.
Detailed change log to describe changes
patch_11795.diff (11.0 KB) - added by dylan 7 years ago.
Revised patch against 1.9 trunk

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by chof@…

Patch for ThumbnailPicker? Enhancements

Changed 9 years ago by chof@…

Test case to show the new functionality of the enhancements

Changed 9 years ago by chof@…

Attachment: changelog.txt added

Detailed change log to describe changes

comment:1 Changed 9 years ago by bill

Component: GeneralDojox
Owner: changed from anonymous to Shane O'Sullivan

Hi, have you filed a CLA (dojofoundation.org/cla)?

comment:2 in reply to:  1 Changed 9 years ago by chof@…

Replying to bill:

Hi, have you filed a CLA (dojofoundation.org/cla)?

Yes

comment:3 Changed 9 years ago by bill

Summary: Enhancement suggestion for ThumbNailPicker[patch] [cla] Enhancement suggestion for ThumbNailPicker

comment:4 Changed 7 years ago by dylan

Milestone: tbd1.9
Owner: changed from Shane O'Sullivan to dylan
Status: newassigned

Adopting this one. Will update to AMD and then try to get this into trunk for 1.9.

comment:5 Changed 7 years ago by dylan

Owner: changed from dylan to chof@…
Status: assignedpending

Before I start updating this to AMD, I wanted to land your patch.

Can you please verify the attached patch, and then I'll do my best to update to AMD before 1.9?

Changed 7 years ago by dylan

Attachment: patch_11795.diff added

Revised patch against 1.9 trunk

comment:6 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.