Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11792 closed enhancement (fixed)

Added ColorPicker to dojox.editor.plugins.ColorTableCell for color selection

Reported by: Gu Yi, He Owned by:
Priority: high Milestone: 1.6
Component: Editor Version: 1.5
Keywords: ibm color table cell Cc: [email protected]…, [email protected]
Blocked By: Blocking:

Description

This patch contains the enhancement code that added ColorPicker? to the dropdown of dojox.editor.plugins.ColorTableCell? so that the user can pick up more colors.

Attachments (1)

TablePlugins.patch (7.9 KB) - added by Adam Peller 10 years ago.
patch from Eldon (IBM, CCLA)

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Adam Peller

Attachment: TablePlugins.patch added

patch from Eldon (IBM, CCLA)

comment:1 Changed 10 years ago by Jared Jurkiewicz

The plugin doesn't work on IE. Please fix and I'll re-review and commit.

comment:2 Changed 10 years ago by Jared Jurkiewicz

Actually, neither does the old one. so ... Will commit as is. If you can track down why it doesn't work on IE, that would be cool.

comment:3 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22954]) Adding in plugin that has better color picker. fixes #11792

comment:4 Changed 10 years ago by Jared Jurkiewicz

(In [22955]) Updating README. refs #11792

comment:5 Changed 10 years ago by Gu Yi, He

Thank you Jared :) In IE, we have to press and drag the mouse to select the cell (just like what we do to select a piece of text), which is quite different from that of Firefox and surprised me when I first looked into the original one. The original one is great and I learnt a lot from it.

Note: See TracTickets for help on using tickets.