Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#11788 closed defect (fixed)

dijit.form.TimeTextBox does not care about constraints

Reported by: Ferdinand Weinberger Owned by: Douglas Hays
Priority: high Milestone: 1.5.1
Component: Dijit - Form Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

if i add constraints to the timetextbox, they have no effect. an exception is "timePattern". "timepattern" seems to work. but others like "visibleIncrement" not.

	constraints: {
	    timePattern: 'HH:mm:ss',
	    clickableIncrement: 'T00:30:00',
	    visibleIncrement: 'T00:30:00',
	}

ive attached two examples. version 1.4 is working. version 1.5 is not.

Attachments (3)

dijit_form_TimeTextBox_dojo1_4.html (847 bytes) - added by Ferdinand Weinberger 9 years ago.
dijit.form.TimeTextBox? dojo 1.4
dijit_form_TimeTextBox_dojo1_5.html (847 bytes) - added by Ferdinand Weinberger 9 years ago.
dijit.form.TimeTextBox? dojo 1.5
11788_15x.patch (2.4 KB) - added by Douglas Hays 9 years ago.
1.5.x patch if needed

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by Ferdinand Weinberger

dijit.form.TimeTextBox? dojo 1.4

Changed 9 years ago by Ferdinand Weinberger

dijit.form.TimeTextBox? dojo 1.5

comment:1 Changed 9 years ago by bill

Owner: set to Douglas Hays

comment:2 Changed 9 years ago by bill

I do see in firebug how _showText() is getting called before postCreate(). Probably what we need is a _setConstraintsAttr() method instead of having that code in postCreate().

comment:3 Changed 9 years ago by Douglas Hays

Milestone: tbd1.6
Status: newassigned

Is this needed in the 1.5 branch?

comment:4 Changed 9 years ago by Douglas Hays

(In [22957]) Refs #11788. Add _setConstraintsAttr to _TimePicker, and a corresponding testcase. !strict

Changed 9 years ago by Douglas Hays

Attachment: 11788_15x.patch added

1.5.x patch if needed

comment:5 Changed 9 years ago by hjiyong

Is it possible to add the fix to 1.5.x? Thank you.

comment:6 Changed 9 years ago by Douglas Hays

(In [23008]) Refs #11788. Backport[22957] to 1.5 branch.

comment:7 Changed 9 years ago by bill

Milestone: 1.61.5.1

comment:8 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

comment:9 Changed 8 years ago by jtoth55

Resolution: fixed
Status: closedreopened

This is not fixed. I just upgraded to 1.6 and the following increments have no effect.

<input dojoAttachPoint="tbStartTime" name="tbStartTime" type="text"

dojoType="dijit.form.TimeTextBox?" required="true" value="T00:00:00"

visibleIncrement="T00:30:00" clickableIncrement="T00:30:00" />

comment:10 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

Please use constraints as already described in this ticket.

comment:11 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.