Opened 10 years ago
Last modified 4 years ago
#11785 assigned defect
[patch] ThumbnailPicker does not scroll to "next" page if last image on current page ends exactly at the right side of the scroller
Reported by: | Owned by: | dylan | |
---|---|---|---|
Priority: | high | Milestone: | 1.15 |
Component: | Dojox | Version: | 1.5 |
Keywords: | ThumbnailPicker | Cc: | |
Blocked By: | Blocking: |
Description
In one of my test cases I have noticed, that the ThumbnailPicker? would not scroll to the "next" page due to a special situation which can occur quite often:
If on the current page the last image is the last yet loaded image and ends exactly with the right border of the scrollable area the widget does not scroll to the next page because
this._showThumbs(i)
is never called as the if statement within the for loop in the _next function never evaluates to true.
I fixed this in my project with the following two changes:
1.) Add a this._showThumbs(this._thumbs.length - 1); after the for loop in _next()
2.) remove the already questioned if statement from _showThumbs() in line 376 (the one with the FIXME: WTF ...)
This removes the problem with the special situation and as far as I could test the widget (and this was pretty much) does not have any other side effects.
Attachments (1)
Change History (4)
Changed 10 years ago by
Attachment: | ThumbnailPicker_bug#11785.diff added |
---|
comment:1 Changed 10 years ago by
Owner: | changed from Adam Peller to dante |
---|
comment:2 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|---|
Owner: | changed from dante to dylan |
Status: | new → assigned |
Summary: | ThumbnailPicker does not scroll to "next" page if last image on current page ends exactly at the right side of the scroller → [patch] ThumbnailPicker does not scroll to "next" page if last image on current page ends exactly at the right side of the scroller |
comment:3 Changed 4 years ago by
Milestone: | 1.13 → 1.15 |
---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
Diff file of fixed code vs. code in release 1.5.0