dojo.dnd.move.constrainedMoveable.onMove doesn't call onMoving, onMoved as it should

[J Cameron Cooper]

The behavior of 'dojo.dnd.Moveable.onMove' is to call a couple of other blank local event (hook) methods: 'onMoved' and 'onMoving', which promise to be called at specific points in 'onMove'.

The child class 'dojo.dnd.move.constrainedMoveable' overrides 'onMove' but doesn't do the "hook" calls like its parent, so 'onMoved' and 'onMoving' in this case never get called, breaking their contract.

The other classes in the file that descend from 'constrainedMoveable' would also have this problem: 'boxConstrainedMoveable', 'parentConstrainedMoveable'.

The 'TimedMoveable?' class also overrides 'onMove', but does call the parent version, so the hook event methods probably do get called.

[J Cameron Cooper]

It's also important, I think, that leftTop get the constrained values, so the method would look like this when patched:

    this.onMoving(mover, leftTop);
    var c = this.constraintBox, s = mover.node.style;
    leftTop.l = (leftTop.l < c.l ? c.l : c.r < leftTop.l ? c.r : leftTop.l);
    leftTop.t = (leftTop.t < c.t ? c.t : c.b < leftTop.t ? c.b : leftTop.t)
    s.left = leftTop.l + "px";
    s.top  = leftTop.t + "px";
    this.onMoved(mover, leftTop);

[Eugene Lazutkin]

(In [23878]) dnd: minor bug in constrained moveables, removed deprecated functions, thx jccooper!, !strict, fixes #11775.