Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11764 closed enhancement (fixed)

AutoUrlLink plugin for Editor

Reported by: Gu Yi, He Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.6
Component: Editor Version: 1.5
Keywords: ibm editor recognize URL Cc: heguyi@…, drschwar@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

This plugin can recognize a URL like string (such as http://www.website.com) and turn it into a hyperlink that points to that URL.

Attachments (1)

AutoUrlLink.patch (8.1 KB) - added by Adam Peller 9 years ago.
updated patch for enter key handling from Eldon (IBM, CCLA)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Adam Peller

Description: modified (diff)

comment:2 Changed 9 years ago by Jared Jurkiewicz

Adding in AutoUrlLink? after review and several fixes [22910]

comment:3 Changed 9 years ago by Jared Jurkiewicz

heguyi: Can you work more on enter key behavior? (Or remove it?) It does not play well with the enterkeyhandling plugin, which modifies the dom to standardize the neter key markup.

It also sometimes (when pressing enter), grabs an extra word. Such as if you type:

foo http://foo.com|bar (And | is where you press enter). It will grab the bar word as part of the link. That's annoying/bad.

Also, it would be good if you did the doc page for this plugin, since you're the primary author. I merely fixed some issues in it.

comment:4 Changed 9 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz

comment:5 in reply to:  3 Changed 9 years ago by Gu Yi, He

Thank you, Jared. I've updated it according to your comments.

  1. The conflict with EnterKeyHandling? is resolved. It is based on the latest EnterKeyHandling? plugin now.
  2. It will not grab extra word now.
  3. Actually, there is a doc under review. Hope I can post it after the review.

comment:6 Changed 9 years ago by Jared Jurkiewicz

That works a LOT better.

I recommend you test it out in other enterkey handling modes (P/DIV) and see if it still works.

-- Jared

Changed 9 years ago by Adam Peller

Attachment: AutoUrlLink.patch added

updated patch for enter key handling from Eldon (IBM, CCLA)

comment:7 Changed 9 years ago by Adam Peller

posted patch from Eldon - "...updated so that the plugin is compatible with *all* the three (BR, DIV, P) enter key mode."

comment:8 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22953]) Update AutoUrlLink? plugin. Fixed issue in ptch with null selection, aded testcase editors with them. fixes #11764

comment:9 Changed 9 years ago by Jared Jurkiewicz

Fixed a minor issue. You weren't checking for null selections (which do occur). And added test editors for each EnterKeyHandling? mode mode just to make sure they work.

Please get the docs page on Dojocampus updated. :)

Otherwise, looks really good.

Note: See TracTickets for help on using tickets.