Opened 10 years ago

Closed 8 years ago

#11759 closed defect (fixed)

[PATCH][CLA]GridContainerLite postCreate call twice unnessary

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.8
Component: DojoX Layout Version: 1.5
Keywords: GridContainerLite Cc:
Blocked By: Blocking:

Description

postCreate: function(){

console.log("dojox.layout.GridContainerLite? ::: postCreate"); this.inherited(arguments);

...
...
...

Call postCreate of dijit.layout._LayoutWidget. this.inherited(arguments);

}

But _LayoutWidget postCreate method was removed at #22778 already.

I am not sure why this.inherited(arguments) call start/end point originally, But even though the last this.inherited(arguments) removed, it looks like that the GridContainer? works well without any problem.

Attachments (1)

GridContainerLight.patch​ (435 bytes) - added by youngho 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by youngho

Attachment: GridContainerLight.patch​ added

comment:1 Changed 9 years ago by Mathevet julien

Hi, Anyone apply this patch ?

comment:2 Changed 8 years ago by bill

Milestone: tbd → 1.8
Owner: set to bill
Status: new → assigned

comment:3 Changed 8 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [29292]:

remove duplicate this.inherited() calls, fixes #11759 !strict, thanks youngho

Note: See TracTickets for help on using tickets.