Opened 9 years ago

Closed 4 years ago

#11748 closed enhancement (patchwelcome)

Make "expressInstall" option for dojox.av.FLAudio configurable

Reported by: Thomas Bachem Owned by: dylan
Priority: low Milestone: 1.11
Component: Dojox Version: 1.5
Keywords: Cc: Mike Wilcox
Blocked By: Blocking:

Description

As sounds are mostly used in the background and for non-critical stuff, it should be possible to suppress any flash installation dialogs and just go on without playing the sound or reacting in another way.

Internet Explorer by the way does even throw a Javascript Error if Flash initialization fails and shows no installation dialog at the moment.

So we need to be able to disable the "expressInstall" option that is handed over to the dojox.embed.Flash object. I attached a short patch file.

Attachments (1)

ExpressInstall.patch (736 bytes) - added by Thomas Bachem 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Thomas Bachem

Attachment: ExpressInstall.patch added

comment:1 Changed 9 years ago by Adam Peller

Cc: Mike Wilcox added
Owner: changed from Adam Peller to Tom Trenka

comment:2 Changed 7 years ago by Tom Trenka

Priority: highlow
Status: newassigned

comment:3 Changed 7 years ago by Tom Trenka

Owner: changed from Tom Trenka to Mike Wilcox

Mike, maybe you'd like to look at these? Not sure how much we're going to support FLAudio anymore...

comment:4 Changed 4 years ago by dylan

Owner: changed from Mike Wilcox to dylan

comment:5 Changed 4 years ago by dylan

Milestone: tbd1.11
Resolution: patchwelcome
Status: assignedclosed

As with the other FLAudio tickets, my apologies that this was ignored for so many years.

Given that flash is quickly being abandoned as something that runs by default on the web, I'm going to mark this as patchwelcome. I know there's a patch. If you want to recreate as a pull request via github following the guidelines at ​https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md , we'll review and land it.

Note: See TracTickets for help on using tickets.