Using dojo 1.5, dijit.Editor does not work with Safari 4

[joel_314]

• Using dojo 1.5, dijit.Editor does not work with Safari 4 : it is impossible to focus and to write anything.

• Using earlier versions of dojo, there is no problem.

[Jared Jurkiewicz]

I do not have access to Safari 4, so cannot verify if this is true or not. I've used Safari, though (many incarnations), with Editor without issue.

[Jared Jurkiewicz]

Confirmed. That is ... quite peculiar. Not sure why that is happening.

[bill]

It's working for me on mac (safari 4.0.5), in test_Editor.html... perhaps you are testing on windows?

[Jared Jurkiewicz]

Bill, I isolated the issue (And yeah, I'm testing on windows). In 1.4 and earlier there was this:

               if(dojo.isSafari){
                       // Safari 4 seems to always append iframe with src=about:blank
                       setTimeout(function(){ifr.setAttribute('src', s);},0);
               }

after the append of the iframe to the page.

It was was removed in 1.5.

Putting it back fixes the issue (and just saying dojo.isSafari <=4 to scope it to older safari).

Also, just swapping the order of the src field set and adding the iframe to the page also seems to. Not sure what is the best fix. I think the src field needed to be set before append for other browsers, but I could be wrong.

What do you think?

[Jared Jurkiewicz]

Potential patch for issue.

[Jared Jurkiewicz]

I threw a patch on that does the isSafari check, but I wanted your take before I committed anything for it. It's def a regression in 1.5.

[Jared Jurkiewicz]

If you want me to just commit my fix into 1.5/1.6, just assign it back to me. :)

[bill]

I took out that code in [22416] to fix #11400... after applying your patch that problem comes back, at least on mac. You could modify your patch to only run that code on windows (when !dojo.isMac), but I'm guessing it will cause the LinkDialog test failure. I suppose that's better than safari 4 not working at all.

[Jared Jurkiewicz]

I'll try a few ideas today and see if any work.

-- Jared

[Jared Jurkiewicz]

Updated to only activate on Windows, since it seems windows specific

[Jared Jurkiewicz]

(In [22949]) Tweak to fix a Safari 4 regression (editor didn't work on Windows at all). \!strict refs #11744

[Jared Jurkiewicz]

(In [22950]) Tweak to fix a Safari 4 regression (editor didn't work on Windows at all). \!strict fixes #11744

[andrew.ortwein]

I am seeing this problem using Safari 4.0.5 on Mac OS X (10.5). If I apply this patch to my deployment of Dojo 1.5 and remove "!dojo.isMac" check from the IF statement, it seems to fix the editor. Can we reopen this ticket and make this change?

[bill]

It's not quite so simple, as I wrote above I took out that code in [22416] to fix #11400... after removing the if(!dojo.isMac) the LinkDialog problem comes back on mac. Maybe we need to branch on the OS.

My userAgent is:

> navigator.userAgent
"Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-us) AppleWebKit/533.18.1 (KHTML, like Gecko) Version/5.0.2 Safari/533.18.5"

What's yours? (You can get the console from Alt-Command-C.)

[bill]

I reproduced this on a Mac 10.5.8 machine running safari 4 only.

I also noticed that MacOS automatically prompts the user to install system updates including Safari 5. So not sure why you are still using Safari 4.

[Jared Jurkiewicz]

Followup patch varient for Saf 4.

[Jared Jurkiewicz]

(In [23105]) Followup patch for Saf 4 issues with Editor startup. Saf 4 bug. \!strict refs #11744

[Jared Jurkiewicz]

(In [23106]) Followup patch for Saf 4 issues with Editor startup. Saf 4 bug. \!strict fixes #11744

[andrew.ortwein]

@bill: Sorry I didn't get back to you sooner. I'm purposely running Safari 4 on a test machine because our product still supports this browser (though I assume most Mac users will have upgraded to Safari 5 by now).

@jaredj: Thanks for adding this fix.