Opened 9 years ago

Closed 9 years ago

#11742 closed defect (fixed)

incorrect doh.assertNotEqual

Reported by: Anirban Mitra Owned by: liucougar
Priority: high Milestone: 1.6
Component: TestFramework Version: 1.5
Keywords: doh.assertNotEqual Cc:
Blocked By: Blocking:

Description

doh.assertNotEqual behaves incorrectly. It uses doh.assertEqual to compare objects like in this case, doh.assertNotEqual({dna: "adas"}, {a: "ad"}), which throws and exception and exits. So even if the objects are not equal it shows failure. Whereas the exception should have been caught and true should have been returned.

( I have attached a trivial patch for this)

Attachments (1)

doh_assertNotEqual.patch (1.1 KB) - added by Anirban Mitra 9 years ago.
doh.assertNotTrue patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Anirban Mitra

Attachment: doh_assertNotEqual.patch added

doh.assertNotTrue patch

comment:1 Changed 9 years ago by bill

Component: GeneralTestFramework
Owner: changed from anonymous to alex

comment:2 Changed 9 years ago by liucougar

Milestone: tbd1.6
Owner: changed from alex to liucougar

comment:3 Changed 9 years ago by liucougar

Resolution: fixed
Status: newclosed

(In [22882]) fixes #11742: _objPropEq throws exception if the two arguments equal to each, need to catch it and return true instead in assertNotEqual !strict

Note: See TracTickets for help on using tickets.