Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11741 closed task (fixed)

convert dijit testcases to HTML5 style

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5
Keywords: Cc: Katie Vance
Blocked By: Blocking:

Description


Change History (29)

comment:1 Changed 9 years ago by Douglas Hays

<input name="cb1" id="cb1" jsid="cb1" value="foo" dojoType="dijit.form.CheckBox"
    onClick="console.log('clicked cb1')">

should be

<input id="cb1" data-dojo-id='cb1' data-dojo-type="dijit.form.CheckBox"
    data-dojo-props="onClick:function(e){ console.log('clicked cb1')}, value:'foo', name:'cb1'">

comment:2 Changed 9 years ago by Douglas Hays

From phiggins,

<span value="bar">Select me</span>

should be:

<span data-dojo-value="bar">Select me</span>

since SPAN cannot contain the value attribute

comment:3 Changed 9 years ago by Douglas Hays

(In [22898]) Refs #11741. Changes to dijit/form testcases to validate against HTML5.

comment:4 Changed 9 years ago by Douglas Hays

(In [22906]) Refs #11741. Fixup some data-dojo-props member types to dijit/form testcases.

comment:5 Changed 9 years ago by bill

(In [22916]) Fix store parameter (it should be a dojo.data store, not a string), refs #11741.

comment:6 Changed 9 years ago by bill

(In [22917]) Fix tabbing/indentation, refs #11741.

comment:7 Changed 9 years ago by bill

(In [22918]) Fix test errors, remove unnecessary type: "text" attributes (it's the default), used named parameters instead of arguments[0], refs #11741.

comment:8 Changed 9 years ago by bill

(In [22919]) get ComboBox/FilteringSelect tests working, refs #11741

comment:9 Changed 9 years ago by bill

(In [22921]) remove unnecessary type:"checkbox" and type:"radio" parameters, refs #11741

comment:10 Changed 9 years ago by Douglas Hays

(In [22922]) Refs #11741. Changes to dijit/layout testcases to validate against HTML5. PHP files not yet converted.

comment:11 Changed 9 years ago by bill

(In [22925]) use named parameters for functions, rather than arguments[0], refs #11741

comment:12 Changed 9 years ago by bill

(In [22928]) convert PHP files in dijit/tests/layout to new data-dojo-type syntax, refs #11741

comment:13 Changed 9 years ago by bill

(In [22930]) Change style declarations for dijit/form tests to use attribute bags (maybe the only syntax we'll support for 2.0?), and remove unnecessary display:none on drop downs, refs #11741.

comment:14 Changed 9 years ago by bill

(In [22931]) remove unnecessary type:"multiple", refs #11741

comment:15 Changed 9 years ago by Douglas Hays

(In [22932]) Refs #11741. Convert validationMessages.html to HTML 5 and make the test run significantly faster.

comment:16 Changed 9 years ago by Douglas Hays

(In [22941]) Refs #11741. Changes to dijit/tests/editor testcases to validate against HTML5.

comment:17 Changed 9 years ago by bill

(In [22943]) Editor doesn't understand HTML5 style declarations for font, need to use old style or else font drop down etc. won't reflect current setting. Plus fixing a few typos. Refs #11741.

comment:18 Changed 9 years ago by Douglas Hays

(In [22951]) Refs #11741. Remaining changes to dijit/tests testcases to validate against HTML5. Declaration.js still uses dojoType/dojoAttachPoint/dojoAttachEvent, and test_bgIframe.html still uses an invalid applet tag (not sure why).

comment:19 Changed 9 years ago by bill

(In [22967]) Fix some datatype issues to get test running, refs #11741.

comment:20 Changed 9 years ago by Douglas Hays

(In [23006]) Refs #11741. Exception being thrown in toJson call due to "class" reserved word.

comment:21 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

comment:22 Changed 9 years ago by bill

(In [23083]) Avoid spurious test failure on IE8 due to browser differences on innerHTML rendering (order attributes are listed, quotes, etc.), refs #11741.

comment:23 Changed 9 years ago by bill

(In [23116]) Missing quotes, refs #11741.

comment:24 Changed 9 years ago by bill

(In [23194]) [22951] set the TitlePane? width to 200px but the contained TabContainer? is 400px... that doesn't make sense, the outer container needs to be wider.

Also fixing spacing.

Refs #11741.

comment:25 Changed 9 years ago by bill

(In [23264]) Since all of the tests are HTML5 format, no need for special HTML5 format tests. Refs #11741.

comment:26 Changed 8 years ago by bill

(In [23447]) More natural argument syntax for onChange handler, plus removing unnecessary (non-I18n related) parts from test, refs #11741.

comment:27 Changed 8 years ago by bill

(In [23448]) More natural argument syntax for callbacks, refs #11741.

comment:28 Changed 8 years ago by bill

(In [23453]) fix typos from [22930], refs #11741.

comment:29 Changed 8 years ago by bill

(In [23454]) "class" needs to be quoted, at least on some browsers, refs #11741.

Note: See TracTickets for help on using tickets.