Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11734 closed defect (fixed)

Enhanced Grid framework enhancement

Reported by: evan Owned by: evan
Priority: high Milestone: 1.6
Component: DojoX Grid Version: 1.5
Keywords: enhanced grid Cc: drschwar@…, xwzhu@…, hwcdl@…, wangqsh@…
Blocked By: Blocking:

Description (last modified by evan)

Used to track common EDG changes/enhancements for 1.6, e.g. newly extended _FocusManager/_Events, new theme structure etc.

Also fixes #7484

Attachments (5)

edg.patch​ (94.3 KB) - added by Adam Peller 9 years ago.
initial patch from Evan
edg-#11734-test-data.patch​ (66.7 KB) - added by evan 9 years ago.
Commonly used testing data
images.zip​ (18.6 KB) - added by evan 9 years ago.
Image files used by various plugins - please put all icon files under "dojox\grid\enhanced\resources\images\"
new-theme-structure.patch​ (18.3 KB) - added by Adam Peller 9 years ago.
From Evan: Reorganize EDG theme following dijit theme styles - so that each plugin will have a separate css
edg-12-8-2010.patch​ (105.0 KB) - added by evan 9 years ago.

Download all attachments as: .zip

Change History (25)

Changed 9 years ago by Adam Peller

Attachment: edg.patch​ added

initial patch from Evan

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from bryanforbes to Evan

Changed 9 years ago by evan

Attachment: edg-#11734-test-data.patch​ added

Commonly used testing data

Changed 9 years ago by evan

Attachment: images.zip​ added

Image files used by various plugins - please put all icon files under "dojox\grid\enhanced\resources\images\"

Changed 9 years ago by Adam Peller

Attachment: new-theme-structure.patch​ added

From Evan: Reorganize EDG theme following dijit theme styles - so that each plugin will have a separate css

comment:2 Changed 9 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [23009]) Fixes #11734. Proxy commit for evan (CCLA). Cleaned _Events, refactored _FocusManager, fixed malformed _Layout, _View. Reorganized EDG theme following dijit theme styles so that each plugin will have a separate css. New tests. New icons. !strict

comment:3 Changed 9 years ago by Douglas Hays

(In [23010]) Refs #11734. Delete obsolete css files.

comment:4 Changed 9 years ago by Douglas Hays

(In [23018]) Refs #11734. Proxy commit for evan (CCLA). Add missing files and clean up code !strict

comment:5 Changed 9 years ago by bill

Owner: changed from Evan to evan

Changed 9 years ago by evan

Attachment: edg-12-8-2010.patch​ added

comment:6 Changed 9 years ago by evan

Patch "edg-12-8-2010.patch" includes following changes:

  1. _Builder/_Layout/_View - no use any more and removed
  1. EnhancedGrid? : Overwrite and split "fetch" a bit so that each plugin can customize fetch more easily.
  1. Events: removed unused code that're no longer used with new NestedSorting/IndirectSelection?
  1. _Plugin: changed/added events e.g. onPreInit, onSetStore etc.
  1. _PluginManager: removed a lot of unused code, func order adjusting, coding style fix
  1. enhanced._FocusManager: many logic cleaned up/removed by mostly reusing logic from grid._FocusManager
  1. StoreLayer?: renamed to '_StoreLayer' since it's internal-use only

8 Other - Cleaned up with unused code removed, func order adjusting, strict coding style fixes etc.

comment:7 Changed 9 years ago by Douglas Hays

(In [23291]) Refs #11734. Proxy commit for evan (IBM, CCLA). Enhanced grid cleanup: removed obsolete files, various code style tweaks, renamed _StoreLayer.js. !strict

comment:8 Changed 8 years ago by evan

Description: modified (diff)

comment:9 Changed 8 years ago by evan

(In [23646]) Refs #11734, typo, trivial issue fixes, css, !strict

comment:10 Changed 8 years ago by evan

(In [23673]) Refs #11734, make test cases more user friendly to understand various usages, delete obsolete test data. !strict

comment:11 Changed 8 years ago by evan

(In [23680]) Refs #11734, focus navigating should skip hidden row or cell nodes, !strict

comment:12 Changed 8 years ago by evan

(In [23769]) Refs #11734, Slight changes to use console.warn() for possible error info, !strict

comment:13 Changed 8 years ago by evan

(In [23770]) Refs #11734, remove an obsolete attr & tweak console.warn() info, !strict

comment:14 Changed 8 years ago by evan

(In [23780]) Fix claro style of selected column & cell; add css sample in test case for how to overwrite the default cell style, refs #11734

comment:15 Changed 8 years ago by evan

(In [23814]) README & comment updates, refs #11734, !strict

comment:16 Changed 8 years ago by evan

(In [23821]) Remove obsolete comments, README update, refs #11734, !strict

comment:17 Changed 8 years ago by evan

(In [23888]) Adjust claro styles of selected rows & test case fix, refs #11734

comment:18 Changed 8 years ago by evan

(In [25194]) Refs #11734 make EDG css path change backward compatible with 1.5, also applied to 1.6 branch

comment:19 Changed 8 years ago by Evan

Cc: drschwar@us.ibm.com,xwzhu@cn.ibm.com,hwcdl@cn.ibm.com,wangqsh@cn.ibm.com → drschwar@us.ibm.com, xwzhu@cn.ibm.com, hwcdl@cn.ibm.com, wangqsh@cn.ibm.com

In [27289]:

Refs #11734 !strict trivial EDG test case fixes

comment:20 Changed 8 years ago by Evan

In [27368]:

Refs #11734 fix broken EDG test cases

Note: See TracTickets for help on using tickets.