Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11723 closed enhancement (fixed)

EnhancedGrid - new DnD support

Reported by: evan Owned by: evan
Priority: high Milestone: 1.6
Component: DojoX Grid Version: 1.5
Keywords: enhanced grid dnd Cc: drschwar@…, xwzhu@…, hwcdl@…,
Blocked By: Blocking:

Description

Provides newly enhanced DnD support for spreadsheet like behavior, including:

1.Moving columns(adjacent or in-adjacent) by key or mouse

2.Moving rows(adjacent or in-adjacent) by key or mouse

3.Moving cells(adjacent or in-adjacent) by key or mouse

4.Follow standard dojo.dnd behavior and support moving rows out of Grid(to other widgets)

​Related discussions on this

Attachments (2)

edg-dnd.JPG​ (52.8 KB) - added by evan 9 years ago.
Adding a snapshot how new dnd works
dnd.patch​ (66.8 KB) - added by Adam Peller 9 years ago.
patch from Evan

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from bryanforbes to Evan

Changed 9 years ago by evan

Attachment: edg-dnd.JPG​ added

Adding a snapshot how new dnd works

Changed 9 years ago by Adam Peller

Attachment: dnd.patch​ added

patch from Evan

comment:2 Changed 9 years ago by Adam Peller

requires #11734

comment:3 Changed 9 years ago by evan

requires ​#11722
Once "dnd.patch" applied, please use dojox/grid/tests/enhanced/test_enhanced_grid_dnd.html

comment:4 Changed 9 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [23050]) Fixes #11723. Proxy commit for evan (CCLA). Refactored DnD code for enhanced grid to allow easier moving of columns, rows, and cells. !strict

comment:5 Changed 9 years ago by bill

Owner: changed from Evan to evan

comment:6 Changed 9 years ago by evan

The above "dnd-12-8-2010.patch" includes following changes:

  1. Improved the performance by changing the style of the avatar instead of keeping appending/removing it from the document.
  1. Supported dragging content(row/cell) from other widgets into grid.
  1. Bug fix - keyboard events should be connected to doc instead of inside the grid because row/cell can be dragged out of grid.
  1. Bug fix - the avatar mark was not correct in RTL.
  1. Bug fix - fixed conflict with selection
  1. Moved DnD css into a separate "DnD.css"
  1. Code clean, removed unused logic, simplify code for styling the selected area.
  1. Test case/data updates

comment:7 Changed 9 years ago by evan

Note: the "dnd-12-8-2010.patch" is re-appended to a new ticket #12065

comment:8 Changed 9 years ago by Douglas Hays

(In [23322]) Fixes #12065, refs #11723. Proxy commit for evan (IBM, CCLA). Various EnhancedGrid? DnD bug fixes and new tests. !strict

Note: See TracTickets for help on using tickets.