Chart incorrectly destroys animations

[Stefan Bird]

If a chart is destroyed while an action is in progress, action2d._Base fails in the following section (around line 72):

df.forIn(this.anim, function(o){

df.forIn(o, function(anim){

anim.action.stop(true);

});

});

It appears the second df.forIn is unnecessary (and incorrect) as o has an action member with a stop method. I'm pretty sure the code should be:

df.forIn(this.anim, function(o){

o.action.stop(true);

});

[Stefan Bird]

Mmm, seems I overlooked how the subclasses were using this.anim - sometimes o is an empty object, so the change I suggested is also incorrect :o(

Easiest way (for me) to reproduce the bug is to create a pie chart with a moveslice animation, and have a button nearby that destroys the chart. Move the cursor over a slice then click the button before the slice has had time to return.

[cjolif]

tentative test-case (not reproducing)

[cjolif]

I tried to reproduce with ​http://bugs.dojotoolkit.org/attachment/ticket/11706/test_animdestroy.html but was not able. Go to the PieChart? at the bottom, go other a slice, a slow MoveSlice? begins, press 'a' while the animation is going on, this will call Chart.destroy() but I don't have any error...

[cjolif]

(I tested it on trunk only)

[Stefan Bird]

I'm still running on 1.5, and because of the refactoring between 1.5 and 1.6 I'm not able to run the test case. For now I guess we can assume that it's already been fixed in trunk; if I encounter the issue again in 1.6 or 1.7 I'll create my own test case and post it here.

[Eugene Lazutkin]

Closing as working in the current trunk. Please reopen, if you find a way to reproduce it.