Opened 9 years ago

Closed 9 years ago

#11695 closed defect (fixed)

4 themes reference _a11y class spelled with LL instead of 11

Reported by: Just Owned by: dylan
Priority: high Milestone: 1.5.1
Component: themes Version: 1.5
Keywords: themes, css, a11y Cc:
Blocked By: Blocking:

Description

The theme stylesheet files:

/dijit/themes/claro/claro.css

/dijit/themes/nihilo/nihilo.css

/dijit/themes/tundra/tundra.css

/dijit/themes/soria/soria.css

all contain a reference to a class called ".dijit_ally" spelled with lowercase LL rather than 11.

In the version checked (1.5) it appears to be only once, at line 86 in each .css file.

<clipping>

.dijit_a11y .dijitPopup,

.dijit_ally .dijitPopup DIV,

.dijit_a11y .dijitPopup TABLE,

.dijit_a11y .dijitTooltipContainer {

background-color: white !important;

}

</clipping>

Change History (7)

comment:1 Changed 9 years ago by dylan

Owner: changed from nonken to dylan
Status: newassigned

comment:2 Changed 9 years ago by dylan

Resolution: fixed
Status: assignedclosed

(In [22843]) fixes #11695, typo in the spelling of a11y

comment:3 Changed 9 years ago by dylan

Milestone: tbd1.6

Note that the actual fix is in dijit.css... the other theme files import this rule, which gets compiled into the built version of Dojo.

Thanks for the catch!

comment:4 Changed 9 years ago by Adam Peller

(In [22844]) Fix typo on 1.5 branch. Fixes #11695, Refs #11174

comment:5 Changed 9 years ago by Adam Peller

Milestone: 1.61.5.1

comment:6 Changed 9 years ago by bill

Resolution: fixed
Status: closedreopened

Thanks guys, but presumably that CSS is uneeded and should be removed, rather than fixing the typo. Did you see an actual problem in how high-contrast mode displays?

comment:7 Changed 9 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [22846]) Remove unneeded CSS rules. These rules might have been left over from when menus etc. were semi-transparent. In true high-contrast mode background-color setting is ignored anyway.

Tested Menu and TooltipDialog on IE and FF in high contrast mode and they look fine w/out this rule. Fixes #11695, refs #3385 ([9100]).

Note: See TracTickets for help on using tickets.