Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#11685 closed enhancement (fixed)

[CLA][patch] dijit.Tree shift-key multi-select support

Reported by: liucougar Owned by: liucougar
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5
Keywords: Cc: bill
Blocked By: Blocking:

Description

the attached patch adds shift-key multi-select support to the dijit.tree._dndSelector (which can be used as the dndController for a dijit.Tree to add multi-selection support) with robot tests

multi-selection is also updated to model how MS Explorer (Windows XP file manager) does multi-select

this patch also exposes some API for manipulating the Tree selections

finally, this patch fixes the issue where NaN shows up in the elapsed time column in doh browser runner UI (by changing setUp to runTest).

Attachments (3)

11685.patch (22.2 KB) - added by liucougar 9 years ago.
shift-key multi-select support for dijit.Tree
11685.2.patch (30.6 KB) - added by liucougar 9 years ago.
revised patch to filter out children items in dnd if parent is selected
11685.3.patch (31.2 KB) - added by liucougar 9 years ago.
revised patch to fix tests for IE

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by liucougar

Attachment: 11685.patch added

shift-key multi-select support for dijit.Tree

Changed 9 years ago by liucougar

Attachment: 11685.2.patch added

revised patch to filter out children items in dnd if parent is selected

comment:1 Changed 9 years ago by liucougar

the new patch above adds a filter to remove children items in dnd if parent is selected. in addition, the selection dictionary in _dndSelector is changed to map id to TreeNode? widget (instead of TreeNode?.rowNode DOM node)

Changed 9 years ago by liucougar

Attachment: 11685.3.patch added

revised patch to fix tests for IE

comment:2 Changed 9 years ago by liucougar

the latest patch fixes IE tests failures, removes Anchor css and cleans up API a bit

comment:3 Changed 9 years ago by liucougar

Resolution: fixed
Status: newclosed

(In [22860]) fixes #11685: dijit.Tree shift-key multi-select support with functional tests

cleanup some API as well. !strict

comment:4 Changed 9 years ago by bill

(In [22966]) Attempt to get multi-dnd tests working on mac, but unfortunately robot keydown/keyup of META key doesn't seem to work. Refs #11685.

comment:5 Changed 9 years ago by haysmark

FYI bill I attached a robot fix to #7681.

comment:6 Changed 9 years ago by bill

(In [22970]) Added support for holding down the META key by itself. Forced mouseMove to stay within upper-left bound of window to prevent it from spuriously aborting tests.

Patch from Mark Hays (IBM, CCLA), thanks! Hope I compiled the jar correctly (it's working for me, and the Tree DnD tests are now running correctly on mac FF).

Refs #7681, #11685.

comment:7 Changed 9 years ago by bill

(In [22971]) Oh, Mark attached DOHRobot.jar to #7681, so using that one. Refs #7681, #11685.

comment:8 Changed 9 years ago by bill

(In [23127]) Get test running on mac, refs #11685.

comment:9 Changed 7 years ago by bill

In [29285]:

Fix intermittent spurious test failure, refs #11685.

comment:10 Changed 5 years ago by Bill Keese <bill@…>

In 88c351c123c69f23f50da4e0b46272aacf4d939c/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.