Select: support .set('store', store)

[ben hockey]

for consistency, dijit.form.Select should be standardized to use select.set('store', store); rather than the custom setStore function currently being used.

[bill]

I thought about that before, but it's a little weird because setStore() takes multiple arguments:

setStore: function(/* dojo.data.api.Identity */ store,
					/* anything? */ selectedValue,
					/* Object? */ fetchArgs){
	// summary:
	//		Sets the store you would like to use with this select widget.
	//		The selected value is the value of the new store to set.  This
	//		function returns the original store, in case you want to reuse
	//		it or something.
	// store: dojo.data.api.Identity
	//		The store you would like to use - it MUST implement Identity,
	//		and MAY implement Notification.
	// selectedValue: anything?
	//		The value that this widget should set itself to *after* the store
	//		has been loaded
	// fetchArgs: Object?
	//		The arguments that will be passed to the store's fetch() function

I guess it's still possible.

[dylan]

This would need to be done for 2.0 given the change in API.

[cjolif]

Sounds more of a enhancement than bug fix to me, and also I think 2.0 was the correct assignment.

[dylan]

While an enhancement compared to current capabilities, it's a bit maddening that this isn't consistent with how this should work.

SitePen? will work on a pull request for this next week.

[bill]

OK, then please assign to someone is SitePen?. We don't want to have unassigned tickets that are scheduled for 1.10.

Also, as is probably obvious, we need to keep the setStore() method because we can't break the old API. Also the change (like all dijit changes) would need to have automated tests.

[bill]

PR is ​https://github.com/dojo/dijit/pull/28.

[Colin Snover <[email protected]…>]

In f2819c211da32799fa9264fc505dcef6d60f8891/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[bill]

See also #16953. Release notes should document that we now have the standard API for setting query, queryOptions, and store.