Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#11676 closed enhancement (fixed)

Select: support .set('store', store)

Reported by: ben hockey Owned by: dylan
Priority: high Milestone: 1.10
Component: Dijit - Form Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

for consistency, dijit.form.Select should be standardized to use select.set('store', store); rather than the custom setStore function currently being used.

Change History (14)

comment:1 Changed 9 years ago by bill

I thought about that before, but it's a little weird because setStore() takes multiple arguments:

setStore: function(/* dojo.data.api.Identity */ store,
					/* anything? */ selectedValue,
					/* Object? */ fetchArgs){
	// summary:
	//		Sets the store you would like to use with this select widget.
	//		The selected value is the value of the new store to set.  This
	//		function returns the original store, in case you want to reuse
	//		it or something.
	// store: dojo.data.api.Identity
	//		The store you would like to use - it MUST implement Identity,
	//		and MAY implement Notification.
	// selectedValue: anything?
	//		The value that this widget should set itself to *after* the store
	//		has been loaded
	// fetchArgs: Object?
	//		The arguments that will be passed to the store's fetch() function

I guess it's still possible.

comment:2 Changed 9 years ago by Douglas Hays

Milestone: tbdfuture
Owner: set to Douglas Hays

comment:3 Changed 9 years ago by bill

Component: DijitDijit - Form

comment:4 Changed 7 years ago by dylan

Milestone: future2.0

This would need to be done for 2.0 given the change in API.

Version 0, edited 7 years ago by dylan (next)

comment:5 Changed 6 years ago by dylan

Milestone: 2.01.10

comment:6 Changed 6 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: newassigned

comment:7 Changed 6 years ago by Douglas Hays

Status: assignedopen

comment:8 Changed 6 years ago by cjolif

Sounds more of a enhancement than bug fix to me, and also I think 2.0 was the correct assignment.

comment:9 Changed 6 years ago by bill

Milestone: 1.102.0

comment:10 Changed 6 years ago by dylan

Milestone: 2.01.10

While an enhancement compared to current capabilities, it's a bit maddening that this isn't consistent with how this should work.

SitePen? will work on a pull request for this next week.

comment:11 Changed 6 years ago by bill

Owner: set to dylan
Status: openassigned

OK, then please assign to someone is SitePen?. We don't want to have unassigned tickets that are scheduled for 1.10.

Also, as is probably obvious, we need to keep the setStore() method because we can't break the old API. Also the change (like all dijit changes) would need to have automated tests.

comment:12 Changed 6 years ago by bill

Type: defectenhancement

comment:13 Changed 6 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: assignedclosed

In f2819c211da32799fa9264fc505dcef6d60f8891/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:14 Changed 6 years ago by bill

Summary: dijit.form.Select uses a custom setStore rather than select.set('store', store);Select: support .set('store', store)

See also #16953. Release notes should document that we now have the standard API for setting query, queryOptions, and store.

Note: See TracTickets for help on using tickets.