#11676 closed enhancement (fixed)
Select: support .set('store', store)
Reported by: | ben hockey | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.10 |
Component: | Dijit - Form | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
for consistency, dijit.form.Select
should be standardized to use select.set('store', store);
rather than the custom setStore
function currently being used.
Change History (14)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Milestone: | tbd → future |
---|---|
Owner: | set to Douglas Hays |
comment:3 Changed 9 years ago by
Component: | Dijit → Dijit - Form |
---|
comment:4 Changed 7 years ago by
Milestone: | future → 2.0 |
---|
This would need to be done for 2.0 given the change in API.
comment:5 Changed 6 years ago by
Milestone: | 2.0 → 1.10 |
---|
comment:6 Changed 6 years ago by
Owner: | Douglas Hays deleted |
---|---|
Status: | new → assigned |
comment:7 Changed 6 years ago by
Status: | assigned → open |
---|
comment:8 Changed 6 years ago by
Sounds more of a enhancement than bug fix to me, and also I think 2.0 was the correct assignment.
comment:9 Changed 6 years ago by
Milestone: | 1.10 → 2.0 |
---|
comment:10 Changed 6 years ago by
Milestone: | 2.0 → 1.10 |
---|
While an enhancement compared to current capabilities, it's a bit maddening that this isn't consistent with how this should work.
SitePen? will work on a pull request for this next week.
comment:11 Changed 6 years ago by
Owner: | set to dylan |
---|---|
Status: | open → assigned |
OK, then please assign to someone is SitePen?. We don't want to have unassigned tickets that are scheduled for 1.10.
Also, as is probably obvious, we need to keep the setStore() method because we can't break the old API. Also the change (like all dijit changes) would need to have automated tests.
comment:12 Changed 6 years ago by
Type: | defect → enhancement |
---|
comment:13 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:14 Changed 6 years ago by
Summary: | dijit.form.Select uses a custom setStore rather than select.set('store', store); → Select: support .set('store', store) |
---|
See also #16953. Release notes should document that we now have the standard API for setting query, queryOptions, and store.
I thought about that before, but it's a little weird because setStore() takes multiple arguments:
I guess it's still possible.