dojo.marginBox results imply it does not handle negative margins correctly

[Jared Jurkiewicz]

dojo.marginBox results imply it does not handle negative margins correctly

A co-worker of mine did some experiments with Marginbox and uncovered it appears to not handle negative margins correctly. He build a testcase demonstrating the issue and it has been attached to this ticket.

[Jared Jurkiewicz]

Testcase using CDN 1.4

[Jared Jurkiewicz]

Testcase using CDN 1.5

[Jared Jurkiewicz]

Results:

Preferences	 
Top Negative Margins
MB Outer::{"l":0,"t":0,"w":588,"h":348}
MB Inner::{"l":44,"t":4,"w":588,"h":348}
CB Outer::{"l":20,"t":20,"w":500,"h":300}
CB Inner::{"l":20,"t":20,"w":500,"h":300}
MB Outer Top Margin::-20
MB Inner Top Margin::-20
No Negative Margins
MB Outer::{"l":0,"t":358,"w":588,"h":388}
MB Inner::{"l":44,"t":402,"w":588,"h":388}
CB Outer::{"l":20,"t":20,"w":500,"h":300}
CB Inner::{"l":20,"t":20,"w":500,"h":300}
MB OuterNN Top Margin::20
MB InnerNN Top Margin::20

Note it isn't taking into account the -20 margin correctly.

[Jared Jurkiewicz]

Top Negative Margins
MB Outer::{"l":0,"t":0,"w":588,"h":348}
MB Inner::{"l":44,"t":4,"w":588,"h":348}
CB Outer::{"l":20,"t":20,"w":500,"h":300}
CB Inner::{"l":20,"t":20,"w":500,"h":300}
MB Outer Top Margin::-20
MB Inner Top Margin::-20
No Negative Margins
MB Outer::{"l":0,"t":358,"w":588,"h":388}
MB Inner::{"l":44,"t":402,"w":588,"h":388}
CB Outer::{"l":20,"t":20,"w":500,"h":300}
CB Inner::{"l":20,"t":20,"w":500,"h":300}
MB OuterNN Top Margin::20
MB InnerNN Top Margin::20

[bill]

Still happens in trunk (pre 1.8) for width. Height seems to be adjusted correctly on FF/mac, although on IE6 it's over-adjusted, subtracting 60 instead of 40.

[dylan]

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.