Selecting linefeed at start of text in Editor causes styling to not be applied - IE issue

[Katie Vance]

From a coworker:

If a linefeed is selected at the start of text in the editor in IE, styling can be applied correctly. However if you try to remove that styling while the text is still highlighted, the styling is not removed. The following steps can be used to reproduce this:

1. Input several lines of text into the Editor for example like below.

---

a b c

---

2. Select characters beginning with a linefeed. In this case, select from the linefeed character just after the character

'a' to the character 'b'.

3. Add a style to the text e.g. Bold, to change the style of selected characters.

The bold styling will be applied.

5. Select the same style button again (in this case bold) to restore the text to it's original format.

Problem: The text remains in bold - the styling is not restored.

This only occurs in IE and only occurs when the linefeed is selected at the start of the highlighted text.

[Katie Vance]

patch to remove empty nodes from the node selection before invoking native browser commands

[Jared Jurkiewicz]

Do you have a CLA on file?

[Katie Vance]

Yeah, I'm working with Doug Hays at IBM.

[Jared Jurkiewicz]

Ah, I expect you're my replacement, then.

[Jared Jurkiewicz]

Updated patch to over-ride the commands using the RickText? over-ride pattern

[Jared Jurkiewicz]

I updated your patch, it had a few issues.

1.) Your functions didn't have comments (summary, params, tags (protected, private, etc).

2.) You had places where you went against dojo style guidelines:

if(foo) { -> if(foo){ No spaces after )

3.) You didn't use the over-ride pattern for commands. The execCommand function itself should not over-ride specific commands, there is a pattern for doing it (_<command>Impl). That way it can easily customize any exec command by mixing in a function of that name, or providing a subclass that included it. (It also allows plugins to attach over-rides). So I moved your if command check into a series of command over-ride functions and returned execCommand to being a generic call.

[Jared Jurkiewicz]

(In [22782]) Applying supplied patch (after a few tweaks), to fix bold.italic/underline issue. \!strict fixes #11649