Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11645 closed enhancement (fixed)

EnhancedGrid - Indirect Selection, use images rather than dijit check box for better performance

Reported by: evan Owned by: evan
Priority: high Milestone: 1.6
Component: DojoX Grid Version: 1.5
Keywords: enhanced grid indirect selection image Cc: hwcdl@…
Blocked By: Blocking:

Description

Ideally indirect selection should use images instead of dijit check boxes to get an ideal performance especially in IE

Attachments (1)

indirect-selection.patch (42.9 KB) - added by Adam Peller 9 years ago.
patch from Evan (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by evan

After a detail check, I found indirect selection couldn't ideally reuse Grid._Selector(like by extending) - since Grid._Selector is a single view without any cell and that means the _Selector view couldn't be integrated into Grid keyboard system(_FocusManager) - while complete keyboard and a11y support are important for us.

So I'm trying another way - keeping the basic structure of current indirect selection while replacing checkbox with images, this way could also simplify the logic a bit, but still there will be a significant issue in a11y - all images will be removed in high contrast mode - though maybe we can use text as tips? e.g. "Checked|UnChecked?". Will post a patch once got any progress.

comment:2 Changed 9 years ago by Adam Peller

Owner: changed from bryanforbes to evan
Summary: hancedGrid - Indirect Selection, use images rather than dijit check box for better performanceEnhancedGrid - Indirect Selection, use images rather than dijit check box for better performance

Changed 9 years ago by Adam Peller

Attachment: indirect-selection.patch added

patch from Evan (IBM, CCLA)

comment:3 Changed 9 years ago by Adam Peller

Description from Evan of latest patch:

  1. Restructured indirectSelection by using images instead of checkboxes|radiobutton for better performance
  2. No change to usage and public API

TODO - improve performance when selecting all/deselecting all with huge rows(>10000) - native grid selection seems not applicable for this case.

comment:4 Changed 9 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [23079]) indirect selection improvement using images instead of checkboxes. proxy commit for Evan. Fixes #11645

comment:5 Changed 9 years ago by bill

Milestone: tbd1.6

comment:6 Changed 8 years ago by evan

(In [23837]) Ignore Space key when indirect selection is on & remove commented code, refs #11645, !strict

Note: See TracTickets for help on using tickets.