Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#11578 closed defect (fixed)

[patch] dojox.widget.Portlet Icons CSS for claro theme missing

Reported by: Ferdinand Weinberger Owned by: bill
Priority: high Milestone: 1.9
Component: themes Version: 1.5
Keywords: portlet claro icons needsreview Cc:
Blocked By: Blocking:

Description

when using a portlet with claro-theme, the icons to toggle, close and show settings are missing. its because the css dojox/widget/Portlet/Portlet.css does not contain rules for claro. for a workaround i used the tundra-icons. see more in attachment.

Attachments (4)

gridcontainer.html (5.4 KB) - added by Ferdinand Weinberger 9 years ago.
gridcontainer with portlet and claro theme. missing css included
11578.patch (5.0 KB) - added by bill 8 years ago.
patch from Felise for proper claro theming
spriteRoundedIconsSmall.png (3.1 KB) - added by bill 8 years ago.
patch from Felise for proper claro theming
11578_updated.patch (6.1 KB) - added by bill 6 years ago.
updated patch but with arrow and hover problems mentioned in comments

Download all attachments as: .zip

Change History (17)

Changed 9 years ago by Ferdinand Weinberger

Attachment: gridcontainer.html added

gridcontainer with portlet and claro theme. missing css included

comment:1 Changed 9 years ago by bill

Hello wuhi, can you file a cla so that we can use your code?

comment:2 in reply to:  1 Changed 9 years ago by Ferdinand Weinberger

Replying to bill:

Hello wuhi, can you file a cla so that we can use your code?

hi bill,

i already have a individual cla. its files under Ferdinand Weinberger

comment:3 Changed 9 years ago by bill

Milestone: tbd1.6
Owner: changed from nonken to bill
Status: newassigned

OK thanks! I'll check in.

comment:4 Changed 9 years ago by bill

(In [22738]) Changes from so that dojox.widget.Portlet displays icons in claro theme. This is just pointing to the tundra icons though; I thought the claro team had designed custom portlet icons for claro? Refs #11578.

comment:5 Changed 9 years ago by bill

Owner: changed from bill to Julie Santilli
Status: assignednew

Changed 8 years ago by bill

Attachment: 11578.patch added

patch from Felise for proper claro theming

Changed 8 years ago by bill

Attachment: spriteRoundedIconsSmall.png added

patch from Felise for proper claro theming

comment:6 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:7 Changed 7 years ago by ben hockey

Keywords: needsreview added

comment:8 Changed 6 years ago by Kitson Kelly

Summary: dojox.widget.Portlet Icons CSS for claro theme missing[patch] dojox.widget.Portlet Icons CSS for claro theme missing

comment:9 Changed 6 years ago by dylan

Milestone: future1.9
Owner: changed from Julie Santilli to bill
Status: newassigned

It looks like this was fixed a while back. Please verify

comment:10 Changed 6 years ago by bill

It's not really fixed, like it says in comment:4 it's just using the tundra icons now. There's a patch attached from Felise for claro specific icons, so I guess I'll check that in, although it's a little strange to be adding a spriteRoundedIconsSmall.png file to dijit that isn't being used by dijit.

comment:11 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

Looking some more, the patch doesn't work well. With tundra theme, the down arrow now points left, hovering an icon makes it disappear, and there's an icon to the left of the title that didn't use to be there.

I'm just going to leave things as they are and mark this as fixed since it sort of works.

Changed 6 years ago by bill

Attachment: 11578_updated.patch added

updated patch but with arrow and hover problems mentioned in comments

comment:12 Changed 6 years ago by bill

In [31192]:

On touchend on the placeholder, focus immediately, rather than delayed by a this.defer(), so that the keyboard pops up. Fixes #11578 , refs #16725 !strict.

comment:13 Changed 6 years ago by bill

Oops, above check-in actually fixed #16978.

Note: See TracTickets for help on using tickets.