Opened 9 years ago

Closed 9 years ago

#11570 closed defect (fixed)

dojox.widget.Roller _set name confliction

Reported by: youngho Owned by: dante
Priority: high Milestone: 1.6
Component: DojoX Widgets Version: 1.5
Keywords: dojox roller Cc:
Blocked By: Blocking:

Description

Because of 22718 change, the method name _set in the dojox.widget.Roller conflict with _Widget._set. I not sure _setUp is proper one but it should be change to something else.

Attachments (1)

dojoxWidgetRoller.patch (635 bytes) - added by youngho 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by youngho

Attachment: dojoxWidgetRoller.patch added

comment:1 Changed 9 years ago by dante

Milestone: tbd1.6
Status: newassigned

I picked setIndex. more verbose but more to style. Thanks for the report @youngho

trivial, maybe consider for 1.5.1?

comment:2 Changed 9 years ago by bill

I introduced _set() into 1.6, not 1.5.1, so there's no reason to put this change into 1.5.1.

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

Looks like dante fixed in [22720] but it didn't catch here.

Note: See TracTickets for help on using tickets.