Opened 9 years ago

Closed 3 years ago

#11563 closed defect (patchwelcome)

IE VML text letters rotated 90 degrees counter-clockwise

Reported by: elbeau Owned by: Eugene Lazutkin
Priority: high Milestone: 1.13
Component: DojoX GFX Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

In two places in vml.js you will see the line:

t.style["v-rotate-letters"]=s.rotated;

Apparently, no matter what the value of s.rotated is, if the v-rotate-letters attribute exists, then IE applies it as if v-rotate-letters is true;

In other words, changing the line of code to say:

t.style["v-rotate-letters"]=false;

...does NOTHING to fix the problem, you must:

if (s.rotated) {
    t.style["v-rotate-letters"]=s.rotated;
}

or IE will always print your letters rotated 90 degrees counter-clockwise.

Change History (5)

comment:1 Changed 9 years ago by elbeau

Oops...forgot to enclose it in a code block...the line actually looks like:

t.style["v-rotate-letters"]=s.rotated;

comment:2 Changed 9 years ago by Eugene Lazutkin

Description: modified (diff)
Milestone: tbd1.5.1
Priority: highnormal
severity: majornormal
Status: newassigned

comment:3 Changed 8 years ago by Eugene Lazutkin

Milestone: 1.5.11.6

Bumping from non-existant 1.5.1 to 1.6.

comment:4 Changed 8 years ago by Eugene Lazutkin

Milestone: 1.6future

Need patch that reliably removes the attribute.

comment:5 Changed 3 years ago by dylan

Milestone: future1.12
Resolution: patchwelcome
Status: assignedclosed

Given that VML only impacts IE8, and that no patch has emerged in 5+ years, I'm closing as patchwelcome. If someone wants to provide a patch that reliably removes the attribute, please reopen and provide a pull request per our current contributing guidelines, https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md

Note: See TracTickets for help on using tickets.