Opened 12 years ago
Closed 7 years ago
#11563 closed defect (patchwelcome)
IE VML text letters rotated 90 degrees counter-clockwise
Reported by: | elbeau | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | DojoX GFX | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
In two places in vml.js
you will see the line:
t.style["v-rotate-letters"]=s.rotated;
Apparently, no matter what the value of s.rotated
is, if the v-rotate-letters
attribute exists, then IE applies it as if v-rotate-letters
is true;
In other words, changing the line of code to say:
t.style["v-rotate-letters"]=false;
...does NOTHING to fix the problem, you must:
if (s.rotated) { t.style["v-rotate-letters"]=s.rotated; }
or IE will always print your letters rotated 90 degrees counter-clockwise.
Change History (5)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Milestone: | tbd → 1.5.1 |
Priority: | high → normal |
severity: | major → normal |
Status: | new → assigned |
comment:4 Changed 11 years ago by
Milestone: | 1.6 → future |
---|
Need patch that reliably removes the attribute.
comment:5 Changed 7 years ago by
Milestone: | future → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | assigned → closed |
Given that VML only impacts IE8, and that no patch has emerged in 5+ years, I'm closing as patchwelcome. If someone wants to provide a patch that reliably removes the attribute, please reopen and provide a pull request per our current contributing guidelines, https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md
Oops...forgot to enclose it in a code block...the line actually looks like: