Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11539 closed defect (fixed)

dijit.Editor's Breadcrumb plugin doesn't destroy totally

Reported by: tuanngo Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5.1
Component: Editor Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

Create the dijit.Editor with plugin dojox.editor.plugins.Breadcrumb programmatically.

After dijit.Editor shows correctly, call editor.destroy() or editor.destroyRecursive().

Check which widgets are left by console.dir(dijit.registry);. Then found 1 dijit.Toolbar and 1 dijit.form.ComboButton?.

Attachments (3)

destroyEditor-breadcrumb-notCleanTotally.html (5.9 KB) - added by tuanngo 9 years ago.
Breadcrumb.patch (560 bytes) - added by Jared Jurkiewicz 9 years ago.
Patch fixing the destroy. Needed to manually clean up the menu. Also changed the toolbar to be destroyRecursive. After changes made, testcase provided passes.
destroyEditor-breadcrumb-notCleanTotally.2.html (5.6 KB) - added by Jared Jurkiewicz 9 years ago.
Modified testcase that removes the extend (to verify changes to Breadcrumb work).

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by tuanngo

comment:1 Changed 9 years ago by bill

Component: GeneralEditor
Owner: anonymous deleted

Good catch.

comment:2 Changed 9 years ago by bill

Owner: set to Jared Jurkiewicz

Changed 9 years ago by Jared Jurkiewicz

Attachment: Breadcrumb.patch added

Patch fixing the destroy. Needed to manually clean up the menu. Also changed the toolbar to be destroyRecursive. After changes made, testcase provided passes.

Changed 9 years ago by Jared Jurkiewicz

Modified testcase that removes the extend (to verify changes to Breadcrumb work).

comment:3 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22704]) Updates to Breadcrumb destroy logic. Ensures cleanup of menu and toolbar. I hd thought the dropDown references would be destroyed properly, but I was wrong, needed to be explicit. fixes #11539

comment:4 Changed 9 years ago by Jared Jurkiewicz

Milestone: tbd1.5.1

comment:5 Changed 9 years ago by Jared Jurkiewicz

Also fixed in 1.5.1 (As well as trunk, in revision [22705]

Note: See TracTickets for help on using tickets.