[regression] Popup context menu on DataGrid throws error.

[gregorokorn]

We just switched from dojo 1.3.1 to 1.5 and all of our DataGrid?'s that define the headerMenu attribute fail to render in IE6 and IE7. Firefox worked fine. My investigation led me to the section of dojo 1.5 javascript below:

---

// Se need to extend dijit.Menu so that we have a getPlaceholders function.
dojo.extend(dijit.Menu, {
        getPlaceholders: function(/*String?*/ label){
                // summary:
                //              returns an array of placeholders with the given label.  There
                //              can be multiples.
                // label:
                //              Label to search for - if not specified, then all placeholders
                //              are returned
                // returns:
                //              An array of placeholders that match the given label
                var r = [];
                var children = this.getChildren();
//failed              children.forEach(function(child){
//worked                dojo.forEach(children, function(child){
                        if(child._isPlaceholder && (!label || child.label == label)){
                                r.push(child);
                        }else if(child._started && child.popup && child.popup.getPlaceholders){

                                r = r.concat(child.popup.getPlaceholders(label));
                        }else if(!child._started && child.dropDownContainer){

                                var node = dojo.query("[widgetId]", child.dropDownContainer)[0];
                                var menu = dijit.byNode(node);
                                if(menu.getPlaceholders){

                                        r = r.concat(menu.getPlaceholders(label));
                                }
                        }
                }, this);
                return r; // dojox.widget.PlaceholderMenuItem[]
        }
});

---

where the failed is the place that threw a javascript error due to the "forEach" function being undefined in IE. I commented it out and used the worked line instread and now both IE and Firefox render fine.

I noticed in the dojo 1.5 release notes this section:

--------------------------------------------------
_Container.getChildren()

Code like

     myWidget.getChildren().forEach(...);

should be changed to

     dojo.forEach(myWidget.getChildren(), ...);

Although getChildren() was always documented as returning a plain array, in version 1.4 it actually returned an array with methods like forEach() and filter(), so some user code may be depending on that.
--------------------------------------------------

and assume that this explains the problem and validates my fix. If so, could this fix be applied for the next version?

Thanks,
Gregor

[bill]

Dup of #11319.