Opened 9 years ago

Closed 9 years ago

#11526 closed defect (fixed)

[patch] [ccla] DataPresentation broken in Chrome 5

Reported by: haysmark Owned by: dante
Priority: high Milestone: 1.6
Component: DojoX Widgets Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

See:

http://archive.dojotoolkit.org/nightly/checkout/dojox/widget/tests/test_DataPresentation.html

It doesn't load at all. This issue is related to a known Chrome bug:

http://code.google.com/p/chromium/issues/detail?id=40931

The fix is to not use for-in loops on regular expression results.

Attachments (1)

11526.patch (435 bytes) - added by haysmark 9 years ago.
Fixes #11526. Chrome 5 has issues with for-in loops on regular expression matches.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by haysmark

Attachment: 11526.patch added

Fixes #11526. Chrome 5 has issues with for-in loops on regular expression matches.

comment:1 Changed 9 years ago by haysmark

I attached a fix.

comment:2 Changed 9 years ago by dylan

I'm going to be pedantic and suggest the following to avoid a lookup each time through the loop:

for(var frag=0, len=fragments.length; frag<len; frag++){

comment:3 Changed 9 years ago by dante

Milestone: tbd1.6
Status: newassigned

comment:4 Changed 9 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [23609]) fixes #11526 - thanks haysmark for the patch. chrome5 issue

Note: See TracTickets for help on using tickets.