Opened 9 years ago
Closed 9 years ago
#11516 closed defect (fixed)
claroGrid.css missing styles for treeGrid
| Reported by: | davidqge | Owned by: | Bryan Forbes |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5.1 |
| Component: | DojoX Grid | Version: | 1.5 |
| Keywords: | treeGrid Claro | Cc: | |
| Blocked By: | Blocking: |
Description
The test_treegrid.html didn't work after changed tundra to claro theme.
Here is the patch too add the styles to claroGrid.css, so test_treegrid.html would work with claro theme.
The values are taken from existing claro/tree.css and tundraGrid.css.
Attachments (1)
Change History (6)
Changed 9 years ago by
| Attachment: | claro-treegrid.patch added |
|---|
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Hi David, please file a CLA so that we can use your patch (and add a comment here when you've filed it), thanks!
Also, the other thing is that we try not to use !important in theme files as it makes life difficult for people trying to override the theme. Can you avoid that usage?
comment:3 Changed 9 years ago by
| Owner: | changed from bryanforbes to Bryan Forbes |
|---|
comment:5 Changed 9 years ago by
| Milestone: | tbd → 1.5.1 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
I fixed this by copying and modifying the tundra styles and I backported it to the 1.5 branch. The patch was not used.
Note: See
TracTickets for help on using
tickets.
Patch is from David Ge