Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11497 closed defect (fixed)

[patch] [ccla] ProgressBar: aria labels not correctly specified

Reported by: Becky Gibson Owned by: Becky Gibson
Priority: high Milestone: 1.6
Component: Accessibility Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

When viewed with MS Inspect tool, the roles of the progress bar are not applied properly. The ARIA roles and properties need to be moved to the outer div element of the progress bar.

This isn't a huge problem because the label is specified and the screen reader is speaking the label but it would be better to have the role properly applied.

Attachments (1)

11497.patch (2.0 KB) - added by Becky Gibson 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Becky Gibson

Attachment: 11497.patch added

comment:1 Changed 9 years ago by Becky Gibson

Summary: ProgressBar: aria labels not correctly specified[patch] [ccla] ProgressBar: aria labels not correctly specified

fairly simple change - needed to modify the template. Submitting for review in case I missed something.

comment:2 Changed 9 years ago by bill

Ah, I see I forgot to change this.label.id to this.labelNode.id in [22522], thanks for catching that. Note though that change is only for trunk, not 1.5.

Also, I don't see a need for a dojoAttachPoint=ariaProgress in the template, since you can just access this.domNode.

Other than that it looks OK.

One minor thing is that

var a,
    b,
    c;

is preferred over

var a;
var b;
var c;

because it saves a few bytes.

comment:3 Changed 9 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [22678]) fixes #11497 adjust aria roles for better screen reader support

comment:4 Changed 9 years ago by bill

Milestone: 1.5.11.6
Note: See TracTickets for help on using tickets.