#11488 closed task (fixed)
[meta] missing dijit DOH tests
Reported by: | Katie Vance | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 1.5 |
Keywords: | Cc: | Katie Vance | |
Blocked By: | Blocking: |
Description
Doh test cases are needed for dijit.
I attached a simple doh test for dijit.form.SimpleTextarea?.
Attachments (41)
Change History (102)
comment:1 Changed 10 years ago by
Milestone: | tbd → 1.6 |
---|
comment:2 Changed 10 years ago by
Summary: | doh.robot test cases needed → SimpleTextArea: robot test |
---|
ksv - thanks for the test case for SimpleTextArea. I've checked one in recently for TextArea but I guess we could use one for SimpleTextArea too. But have you filed a CLA?
About the list above, I wouldn't expect a 1-1 mapping between manual test files and automated test files although I guess that would be ideal. In any case each widget should have an automated test, which is why I've filed many tickets like #10340, #10341, #10342, #10343, #10344, #10366 etc.
In any case, we've already got a generic ticket #7681 for robot test cases (in addition to the widget specific tickets I listed above), so I'm going to use this ticket just for tracking SimpleTextArea. Please open other individual tickets for other widgets that are missing automated tests.
comment:3 Changed 10 years ago by
Oh nevermind, I see you have a CLA (under IBM) and also that this ticket is assigned to Doug, didn't realize that before.
comment:4 Changed 10 years ago by
(In [22612]) References #11488. Proxy commit for ksv (CCLA, IBM). Added SimpleTextArea?.html automated test.
Changed 10 years ago by
Attachment: | ComboBox_destroy.patch added |
---|
Changed 10 years ago by
Attachment: | Form_onsubmit.patch added |
---|
comment:5 Changed 10 years ago by
comment:6 Changed 10 years ago by
Changed 10 years ago by
Attachment: | ValidationState.patch added |
---|
robot test for test_validationState.html
comment:7 Changed 10 years ago by
MultiSelect?.html fails consistently on IE7.
{"easing":["dojo._defaultEasing","_scopeName","_base","registry","getUniqueId","isCollapsed","moveToBookmark","focus","registerIframe","registerWin","_onBlurNode","_onFocusNode","getViewport","_place","placeOnScreenAroundRectangle","placementRegistry","getPopupAroundAlignment","popup","BackgroundIframe","typematic","_XhtmlRoles","getWaiRole","removeWaiRole","getWaiState","removeWaiState","_connectOnUseEventHandler","_Templated","layout","form","_HasDropDown"],"second":["getLastInTabbingOrder"],"select3":["TN","FL"]} [ Error: test timeout in formSubmit ] ERROR IN: function() Total time for GROUP " dijit.form.MultiSelect " is 38.4s FAILED test: formSubmit 15031 ms
Even though it's a timeout, adding more time won't help. Clicking the submit button printed the form values to the console, but some other event must have been missed that notified the test.
Also I noticed that different items are being selected in IE vs FF during previous tests but those tests passed anyway so the test criteria needs to be tightened to detect that, AND the test should be altered to not select different items on different browsers. IE selected _destroyAll thru _curFocus and FF selected getEnclosingWidget thru _curFocus.
comment:8 Changed 10 years ago by
(In [22721]) References #11488. Proxy commit for ksv (CCLA). Add an automated ValidationState?.html test.
Changed 10 years ago by
Attachment: | AccordianContainerDestroy.patch added |
---|
robot test for test_AccordionContainerDestroy.html
Changed 10 years ago by
Attachment: | BorderContainer_complex.patch added |
---|
robot test for test_BorderContainer_complex.html
Changed 10 years ago by
Attachment: | BorderContainer_full.patch added |
---|
robot test for test_BorderContainer_full.html
Changed 10 years ago by
Attachment: | MultiSelect.patch added |
---|
comment:9 Changed 10 years ago by
(In [22740]) References #11488. Proxy commit for ksv (CCLA). Add an automated MultiSelect?.html test.
Changed 10 years ago by
Attachment: | BorderContainer_nested.patch added |
---|
robot test for test_BorderContainer_nested.html
Changed 10 years ago by
Attachment: | test_AccordianContainer.patch added |
---|
Move test_AccordionContainerDestroy to test_AccordionContainer
comment:11 Changed 10 years ago by
comment:12 Changed 10 years ago by
comment:13 Changed 10 years ago by
comment:14 Changed 10 years ago by
comment:15 Changed 10 years ago by
(In [22794]) On AccordionContainer.removeChild(child), remove child from AccordionInnerContainer wrapper before destroying wrapper, so that child DOM nodes don't get destroyed along with wrapper. Fixes #11656.
Also fixing the destroy() test in !AccordionContainer_a11y.html (it would never fail even if Accordion was broken), and moving that test to AccordionContainer.html since it works w/out robot. Refs #11488 ([22787]).
Changed 10 years ago by
Attachment: | BorderContainer_prog.patch added |
---|
robot test for test_BorderContainer_prog.html
comment:16 Changed 10 years ago by
comment:17 Changed 10 years ago by
Changed 10 years ago by
Attachment: | ToggleDir_rtl.patch added |
---|
robot test for test_ToggleDir_rtl.html
Changed 10 years ago by
Attachment: | Editor_misc.patch added |
---|
robot test for test_RichText.hml, removed test_resize.html
Changed 10 years ago by
Attachment: | ContentPane_prog.patch added |
---|
robot test for test_ContentPane_prog.html
comment:18 Changed 10 years ago by
comment:19 Changed 10 years ago by
Changed 10 years ago by
Attachment: | LayoutContainer.patch added |
---|
robot test for test_LayoutContainer.html
Changed 10 years ago by
Attachment: | StackContainer.patch added |
---|
robot test for test_StackContainer.html and test_StackContainer_code.hml
Changed 10 years ago by
Attachment: | TabContainer_noLayout.patch added |
---|
robot test for test_TabContainer_noLayout.html
Changed 10 years ago by
Attachment: | TabContainer_prog.patch added |
---|
robot test for test_TabContainer_prog.html
Changed 10 years ago by
Attachment: | TabContainer_remote.patch added |
---|
robot test for test_TabContainer_remote.html
Changed 10 years ago by
Attachment: | Dialog_focusDestroy.patch added |
---|
robot test for test_Dialog_focusDestroy.html
comment:20 Changed 10 years ago by
comment:21 Changed 10 years ago by
comment:22 Changed 10 years ago by
comment:24 Changed 10 years ago by
comment:25 Changed 10 years ago by
Remaining tests to automate:
_base/test_CrossWindow.html (and add both _testCommon.js and claro) bidi.html (need to test both LTR and RTL tests on same page) editor/nls_8859-2.html (add _testCommon.js and be mindful that simplistic text editors can munge special characters) editor/nls_sjis.html (ditto) editor/nls_utf8.html (ditto) layout/test_Gui.html layout/test_refreshOnShow.html test_ProgressBar.html test_bgIframe.html (may need the robot to expose its pixel-read api) test_instantiate.html tree/test_CustomLabel.html tree/test_Tree_Styling.html (merge into Tree.html(nonrobot) or test_Tree.html(robot) and delete this) tree/test_Tree_v1.html
comment:26 Changed 10 years ago by
(In [23056]) Refs #11488. Proxy commit for ksv (CCLA). Add automated ProgressBar?.html test.
comment:27 Changed 10 years ago by
Changed 10 years ago by
Attachment: | Tree_Styling.patch added |
---|
moved test_Tree_Styling.html into Tree.html. No new robot test.
comment:28 Changed 10 years ago by
Changed 10 years ago by
Attachment: | refreshOnShow.patch added |
---|
Delete refreshOnShow.html and move accordion test to acc test page
comment:29 Changed 10 years ago by
Changed 10 years ago by
Attachment: | CustomLabel.patch added |
---|
automated test for test_CustomLabel.html
comment:30 Changed 10 years ago by
(In [23072]) Refs #11488. Proxy commit for ksv (CCLA). Renamed CustomLabel?.html test file and added automated test.
comment:32 Changed 10 years ago by
Changed 10 years ago by
Attachment: | Instantiate.patch added |
---|
robot test will have failures due to #11906
comment:33 Changed 10 years ago by
Changed 10 years ago by
Attachment: | nls_8859-2.html added |
---|
inline automated test for nls_8859-2.html
Changed 10 years ago by
comment:34 Changed 10 years ago by
(In [23145]) Refs #11488. Proxy commit for ksv (CCLA). Add an automated CrossWindow?.html robot test.
comment:35 Changed 10 years ago by
comment:36 Changed 10 years ago by
comment:37 Changed 10 years ago by
The only test left to automate is test_bgIframe.html. I haven't written the test yet because I'm blocked by ticket #11822.
comment:38 Changed 10 years ago by
comment:39 Changed 10 years ago by
comment:40 Changed 10 years ago by
BgIframe?.patch needs more work. On my IE6 XP box with java 1.6.0_20-b02, the test does not load the applet and just hangs. If I remove the programmatic applet and restore the markup applet, it runs with 0 errors.
comment:41 Changed 10 years ago by
comment:42 Changed 10 years ago by
Another missing robot test is for CheckBox/RadioButton, see #10340.
comment:43 Changed 10 years ago by
(In [23277]) Dijit has extensive ContentPane tests, including tests for set("content", ...) and set("href", ...); it doesn't need a special test for programmatic ContentPane creation, certainly not a robot test. This test was probably added for documentation reasons but now we have that on the doc site. Refs #11488.
comment:44 Changed 10 years ago by
(In [23278]) Rewrite LayoutContainer test.
The main thing to check is that LayoutContainer lays out it's children correctly (in top/bottom/left/right/center alignment). This doesn't require robot.
The other thing to test is tab order, which we usually test via robot keyboard commands, but instead I implemented some test code to search for tabbable nodes programatically.
Refs #11488 !strict.
Changed 10 years ago by
Attachment: | BgIframe.patch added |
---|
Changed 10 years ago by
Attachment: | DOHRobot.jar added |
---|
Robot jar to fix issues with applets that steal focus.
Changed 10 years ago by
Attachment: | 11488.patch added |
---|
Refs #11488. Addresses issues with applets stealing focus.
comment:45 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:46 Changed 10 years ago by
comment:47 Changed 10 years ago by
comment:48 Changed 10 years ago by
comment:49 Changed 10 years ago by
comment:52 Changed 10 years ago by
comment:54 Changed 10 years ago by
(In [23484]) Use persist=false flag on Tree rather than manually trying to set TreeNodes to a consistent state. The code to set TreeNodes to a consistent state was incomplete; it didn't adjust grandchildren, and whenever the test was run without clearing the cache, Mexico started out open, causing failures.
Also switching this test to old parser style of dojoType since the test is designed to test backwards compatibility.
Refs #11488.
comment:55 Changed 10 years ago by
Summary: | SimpleTextArea: robot test → [meta] missing dijit DOH tests |
---|
Here are some dijit test files for which I was unable to find corresponding automated tests: