Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#11488 closed task (fixed)

[meta] missing dijit DOH tests

Reported by: Katie Vance Owned by: Douglas Hays
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5
Keywords: Cc: Katie Vance
Blocked By: Blocking:

Description

Doh test cases are needed for dijit.

I attached a simple doh test for dijit.form.SimpleTextarea?.

Attachments (41)

SimpleTextarea.patch (6.0 KB) - added by Katie Vance 9 years ago.
patch order: 1
ComboBox_destroy.patch (3.9 KB) - added by Katie Vance 9 years ago.
Form_onsubmit.patch (11.4 KB) - added by Katie Vance 9 years ago.
ValidationState.patch (8.1 KB) - added by Katie Vance 9 years ago.
robot test for test_validationState.html
AccordianContainerDestroy.patch (3.9 KB) - added by Katie Vance 9 years ago.
robot test for test_AccordionContainerDestroy.html
BorderContainer_complex.patch (26.1 KB) - added by Katie Vance 9 years ago.
robot test for test_BorderContainer_complex.html
BorderContainer_full.patch (10.4 KB) - added by Katie Vance 9 years ago.
robot test for test_BorderContainer_full.html
MultiSelect.patch (11.5 KB) - added by Katie Vance 9 years ago.
BorderContainer_nested.patch (3.7 KB) - added by Katie Vance 9 years ago.
robot test for test_BorderContainer_nested.html
test_AccordianContainer.patch (3.8 KB) - added by Katie Vance 9 years ago.
Move test_AccordionContainerDestroy to test_AccordionContainer
BorderContainer_prog.patch (5.7 KB) - added by Katie Vance 9 years ago.
robot test for test_BorderContainer_prog.html
CustomPlugin.patch (5.3 KB) - added by Katie Vance 9 years ago.
robot test for test_CustomPlugin.html
TabIndent.patch (6.8 KB) - added by Katie Vance 9 years ago.
robot test for test_TabIndent.html
ToggleDir_rtl.patch (6.4 KB) - added by Katie Vance 9 years ago.
robot test for test_ToggleDir_rtl.html
Editor_misc.patch (8.7 KB) - added by Katie Vance 9 years ago.
robot test for test_RichText.hml, removed test_resize.html
ToggleDir.patch (6.0 KB) - added by Katie Vance 9 years ago.
robot test for test_ToggleDir.html
ContentPane_prog.patch (3.8 KB) - added by Katie Vance 9 years ago.
robot test for test_ContentPane_prog.html
LayoutContainer.patch (20.6 KB) - added by Katie Vance 9 years ago.
robot test for test_LayoutContainer.html
StackContainer.patch (15.7 KB) - added by Katie Vance 9 years ago.
robot test for test_StackContainer.html and test_StackContainer_code.hml
TabContainer_noLayout.patch (25.4 KB) - added by Katie Vance 9 years ago.
robot test for test_TabContainer_noLayout.html
TabContainer_prog.patch (9.6 KB) - added by Katie Vance 9 years ago.
robot test for test_TabContainer_prog.html
TabContainer_remote.patch (11.2 KB) - added by Katie Vance 9 years ago.
robot test for test_TabContainer_remote.html
Dialog_focusDestroy.patch (4.0 KB) - added by Katie Vance 9 years ago.
robot test for test_Dialog_focusDestroy.html
Menu_iframe.patch (8.3 KB) - added by Katie Vance 9 years ago.
robot test for test_Menu_iframe.html
ProgressBar.patch (18.0 KB) - added by Katie Vance 9 years ago.
robot test for test_ProgressBar.html
GUI.patch (15.7 KB) - added by Katie Vance 9 years ago.
robot test for test_GUI.html
Tree_Styling.patch (7.4 KB) - added by Katie Vance 9 years ago.
moved test_Tree_Styling.html into Tree.html. No new robot test.
refreshOnShow.patch (7.6 KB) - added by Katie Vance 9 years ago.
Delete refreshOnShow.html and move accordion test to acc test page
CustomLabel.patch (4.2 KB) - added by Katie Vance 9 years ago.
automated test for test_CustomLabel.html
Tree_v1.patch (13.3 KB) - added by Katie Vance 9 years ago.
robot test for test_Tree_v1.html
Instantiate.patch (9.4 KB) - added by Katie Vance 9 years ago.
robot test will have failures due to #11906
CrossWindow.patch (5.5 KB) - added by Katie Vance 9 years ago.
robot test for test_CrossWindow.html
Bidi.patch (27.8 KB) - added by Katie Vance 9 years ago.
robot test for test_Bidi.html
nls_utf8.html (1.9 KB) - added by Katie Vance 9 years ago.
automated test
nls_sjis.html (1.9 KB) - added by Katie Vance 9 years ago.
inline automated test for nls_sjis.html
nls_8859-2.html (2.0 KB) - added by Katie Vance 9 years ago.
inline automated test for nls_8859-2.html
module.js (2.8 KB) - added by Katie Vance 9 years ago.
test.pdf (13.0 KB) - added by Katie Vance 9 years ago.
PDF file needed for BgIframe?.patch
BgIframe.patch (15.3 KB) - added by Katie Vance 9 years ago.
DOHRobot.jar (44.8 KB) - added by haysmark 9 years ago.
Robot jar to fix issues with applets that steal focus.
11488.patch (2.4 KB) - added by haysmark 9 years ago.
Refs #11488. Addresses issues with applets stealing focus.

Download all attachments as: .zip

Change History (102)

comment:1 Changed 9 years ago by Douglas Hays

Milestone: tbd1.6

Here are some dijit test files for which I was unable to find corresponding automated tests:

_base/test_CrossWindow.html
editor/test_CustomPlugin.html
editor/test_Print.html
editor/test_RichText.html
editor/test_TabIndent.html
editor/test_ToggleDir.html
editor/test_ToggleDir_rtl.html
editor/test_resize.html
form/test_ComboBox_destroy.html
form/test_Form_onsubmit.html
form/test_MultiSelect.html
form/test_SimpleTextarea.html
form/test_validStatePerformance.html
form/test_validationState.html
layout/test_AccordionContainerDestroy.html
layout/test_BorderContainer_complex.html
layout/test_BorderContainer_experimental.html
layout/test_BorderContainer_full.html
layout/test_BorderContainer_nested.html
layout/test_BorderContainer_prog.html
layout/test_ContentPane_prog.html
layout/test_Gui.html
layout/test_LayoutContainer.html
layout/test_SplitContainer.html
layout/test_StackContainer.html
layout/test_StackContainer_code.html
layout/test_TabContainerTitlePane.html
layout/test_TabContainer_noLayout.html
layout/test_TabContainer_prog.html
layout/test_TabContainer_remote.html
layout/test_refreshOnShow.html
test_Declaration.html
test_Dialog_focusDestroy.html
test_Menu_iframe.html
test_ProgressBar.html
test_Tree_Notification_API_Support.html
test_bgIframe.html
test_instantiate.html
tree/test_CustomLabel.html
tree/test_Tree_Programmatic.html
tree/test_Tree_Styling.html
tree/test_Tree_v1.html

comment:2 Changed 9 years ago by bill

Summary: doh.robot test cases neededSimpleTextArea: robot test

ksv - thanks for the test case for SimpleTextArea. I've checked one in recently for TextArea but I guess we could use one for SimpleTextArea too. But have you filed a CLA?

About the list above, I wouldn't expect a 1-1 mapping between manual test files and automated test files although I guess that would be ideal. In any case each widget should have an automated test, which is why I've filed many tickets like #10340, #10341, #10342, #10343, #10344, #10366 etc.

In any case, we've already got a generic ticket #7681 for robot test cases (in addition to the widget specific tickets I listed above), so I'm going to use this ticket just for tracking SimpleTextArea. Please open other individual tickets for other widgets that are missing automated tests.

comment:3 Changed 9 years ago by bill

Oh nevermind, I see you have a CLA (under IBM) and also that this ticket is assigned to Doug, didn't realize that before.

Changed 9 years ago by Katie Vance

Attachment: SimpleTextarea.patch added

patch order: 1

comment:4 Changed 9 years ago by Douglas Hays

(In [22612]) References #11488. Proxy commit for ksv (CCLA, IBM). Added SimpleTextArea?.html automated test.

Changed 9 years ago by Katie Vance

Attachment: ComboBox_destroy.patch added

Changed 9 years ago by Katie Vance

Attachment: Form_onsubmit.patch added

comment:5 Changed 9 years ago by Douglas Hays

(In [22684]) References #11488. Proxy commit for ksv (CCLA). Add an automated ComboBox? destroy test and remove unnecessary extra test file test_ComboBox_destroy.html.

comment:6 Changed 9 years ago by Douglas Hays

(In [22691]) References #11488. Proxy commit for ksv (CCLA). Add an automated Form_onsubmit.html test.

Changed 9 years ago by Katie Vance

Attachment: ValidationState.patch added

robot test for test_validationState.html

comment:7 Changed 9 years ago by Douglas Hays

MultiSelect?.html fails consistently on IE7.

{"easing":["dojo._defaultEasing","_scopeName","_base","registry","getUniqueId","isCollapsed","moveToBookmark","focus","registerIframe","registerWin","_onBlurNode","_onFocusNode","getViewport","_place","placeOnScreenAroundRectangle","placementRegistry","getPopupAroundAlignment","popup","BackgroundIframe","typematic","_XhtmlRoles","getWaiRole","removeWaiRole","getWaiState","removeWaiState","_connectOnUseEventHandler","_Templated","layout","form","_HasDropDown"],"second":["getLastInTabbingOrder"],"select3":["TN","FL"]}
[ Error: test timeout in formSubmit ]
ERROR IN: function()
Total time for GROUP " dijit.form.MultiSelect " is 38.4s
FAILED test: formSubmit 15031 ms

Even though it's a timeout, adding more time won't help. Clicking the submit button printed the form values to the console, but some other event must have been missed that notified the test.
Also I noticed that different items are being selected in IE vs FF during previous tests but those tests passed anyway so the test criteria needs to be tightened to detect that, AND the test should be altered to not select different items on different browsers. IE selected _destroyAll thru _curFocus and FF selected getEnclosingWidget thru _curFocus.

comment:8 Changed 9 years ago by Douglas Hays

(In [22721]) References #11488. Proxy commit for ksv (CCLA). Add an automated ValidationState?.html test.

Changed 9 years ago by Katie Vance

robot test for test_AccordionContainerDestroy.html

Changed 9 years ago by Katie Vance

robot test for test_BorderContainer_complex.html

Changed 9 years ago by Katie Vance

Attachment: BorderContainer_full.patch added

robot test for test_BorderContainer_full.html

Changed 9 years ago by Katie Vance

Attachment: MultiSelect.patch added

comment:9 Changed 9 years ago by Douglas Hays

(In [22740]) References #11488. Proxy commit for ksv (CCLA). Add an automated MultiSelect?.html test.

Changed 9 years ago by Katie Vance

robot test for test_BorderContainer_nested.html

Changed 9 years ago by Katie Vance

Move test_AccordionContainerDestroy to test_AccordionContainer

comment:10 Changed 9 years ago by Douglas Hays

BorderContainer_prog should be merged into test_BorderContainer

comment:11 Changed 9 years ago by Douglas Hays

(In [22787]) Refs #11488. Proxy commit for ksv (CCLA). Merged test_AccordionContainerDestroy.html into test_AccordionContainer.html and added an automated test.

comment:12 Changed 9 years ago by Douglas Hays

(In [22791]) References #11488. Proxy commit for ksv (CCLA). Add an automated BorderContainer_complex.html robot test.

comment:13 Changed 9 years ago by Douglas Hays

(In [22792]) References #11488. Proxy commit for ksv (CCLA). Add an automated BorderContainer_full.html robot test.

comment:14 Changed 9 years ago by Douglas Hays

(In [22793]) References #11488. Proxy commit for ksv (CCLA). Add an automated BorderContainer_nested.html robot test.

comment:15 Changed 9 years ago by bill

(In [22794]) On AccordionContainer.removeChild(child), remove child from AccordionInnerContainer wrapper before destroying wrapper, so that child DOM nodes don't get destroyed along with wrapper. Fixes #11656.

Also fixing the destroy() test in !AccordionContainer_a11y.html (it would never fail even if Accordion was broken), and moving that test to AccordionContainer.html since it works w/out robot. Refs #11488 ([22787]).

Changed 9 years ago by Katie Vance

Attachment: BorderContainer_prog.patch added

robot test for test_BorderContainer_prog.html

comment:16 Changed 9 years ago by Douglas Hays

(In [22801]) Refs #11488. Proxy commit for ksv (CCLA). Merged test_BorderContainer_prog.html into test_BorderContainer.html and added an automated test for programmatic creation.

Changed 9 years ago by Katie Vance

Attachment: CustomPlugin.patch added

robot test for test_CustomPlugin.html

comment:17 Changed 9 years ago by Douglas Hays

(In [22862]) Refs #11488. Proxy commit for ksv (CCLA). Added new automated test for editor/test_CustomPlugin.html. Added a workaround for an IE positioning problem in the unit testcase.

Changed 9 years ago by Katie Vance

Attachment: TabIndent.patch added

robot test for test_TabIndent.html

Changed 9 years ago by Katie Vance

Attachment: ToggleDir_rtl.patch added

robot test for test_ToggleDir_rtl.html

Changed 9 years ago by Katie Vance

Attachment: Editor_misc.patch added

robot test for test_RichText.hml, removed test_resize.html

Changed 9 years ago by Katie Vance

Attachment: ToggleDir.patch added

robot test for test_ToggleDir.html

Changed 9 years ago by Katie Vance

Attachment: ContentPane_prog.patch added

robot test for test_ContentPane_prog.html

comment:18 Changed 9 years ago by Douglas Hays

(In [22923]) Refs #11488. Proxy commit for ksv (CCLA). Added new automated Editor tests.

comment:19 Changed 9 years ago by Douglas Hays

(In [22924]) Refs #11488. Handle some Editor tests deletes/renames.

Changed 9 years ago by Katie Vance

Attachment: LayoutContainer.patch added

robot test for test_LayoutContainer.html

Changed 9 years ago by Katie Vance

Attachment: StackContainer.patch added

robot test for test_StackContainer.html and test_StackContainer_code.hml

Changed 9 years ago by Katie Vance

Attachment: TabContainer_noLayout.patch added

robot test for test_TabContainer_noLayout.html

Changed 9 years ago by Katie Vance

Attachment: TabContainer_prog.patch added

robot test for test_TabContainer_prog.html

Changed 9 years ago by Katie Vance

Attachment: TabContainer_remote.patch added

robot test for test_TabContainer_remote.html

Changed 9 years ago by Katie Vance

Attachment: Dialog_focusDestroy.patch added

robot test for test_Dialog_focusDestroy.html

Changed 9 years ago by Katie Vance

Attachment: Menu_iframe.patch added

robot test for test_Menu_iframe.html

comment:20 Changed 9 years ago by Douglas Hays

(In [22996]) Refs #11488. Proxy commit for ksv (CCLA). Added new automated dijit/layout tests.

comment:21 Changed 9 years ago by Douglas Hays

(In [22997]) Refs #11488. Proxy commit for ksv (CCLA). Added new automated dijit/Dialog test.

comment:22 Changed 9 years ago by Douglas Hays

(In [22998]) Refs #11488. Proxy commit for ksv (CCLA). Added new automated dijit/Menu_iframe test.

comment:23 Changed 9 years ago by Douglas Hays

(In [22999]) Refs #11488. Delete obsolete test.

comment:24 Changed 9 years ago by Douglas Hays

(In [23016]) Refs #11488. Reorganize dijit.Tree tests under tree/ directory and remove redundant test files. !strict

comment:25 Changed 9 years ago by Douglas Hays

Remaining tests to automate:

_base/test_CrossWindow.html (and add both _testCommon.js and claro)
bidi.html (need to test both LTR and RTL tests on same page)
editor/nls_8859-2.html (add _testCommon.js and be mindful that simplistic text editors can munge special characters)
editor/nls_sjis.html (ditto)
editor/nls_utf8.html (ditto)
layout/test_Gui.html
layout/test_refreshOnShow.html
test_ProgressBar.html
test_bgIframe.html (may need the robot to expose its pixel-read api)
test_instantiate.html
tree/test_CustomLabel.html
tree/test_Tree_Styling.html (merge into Tree.html(nonrobot) or test_Tree.html(robot) and delete this)
tree/test_Tree_v1.html

Changed 9 years ago by Katie Vance

Attachment: ProgressBar.patch added

robot test for test_ProgressBar.html

Changed 9 years ago by Katie Vance

Attachment: GUI.patch added

robot test for test_GUI.html

comment:26 Changed 9 years ago by Douglas Hays

(In [23056]) Refs #11488. Proxy commit for ksv (CCLA). Add automated ProgressBar?.html test.

comment:27 Changed 9 years ago by Douglas Hays

(In [23057]) Refs #11488. Proxy commit for ksv (CCLA). Added automated layout/GUI.html test.

Changed 9 years ago by Katie Vance

Attachment: Tree_Styling.patch added

moved test_Tree_Styling.html into Tree.html. No new robot test.

comment:28 Changed 9 years ago by Douglas Hays

(In [23058]) Refs #11488. Proxy commit for ksv (CCLA). Merged test_Tree_Styling.html into Tree.html and added an automated test.

Changed 9 years ago by Katie Vance

Attachment: refreshOnShow.patch added

Delete refreshOnShow.html and move accordion test to acc test page

comment:29 Changed 9 years ago by Douglas Hays

(In [23071]) Refs #11488. Proxy commit for ksv (CCLA). Merged test_refreshOnShow.html into test_AccordionContainer.html and added an automated test.

Changed 9 years ago by Katie Vance

Attachment: CustomLabel.patch added

automated test for test_CustomLabel.html

comment:30 Changed 9 years ago by Douglas Hays

(In [23072]) Refs #11488. Proxy commit for ksv (CCLA). Renamed CustomLabel?.html test file and added automated test.

comment:31 Changed 9 years ago by Douglas Hays

missing module.js change for CustomLabel?.html

Changed 9 years ago by Katie Vance

Attachment: Tree_v1.patch added

robot test for test_Tree_v1.html

comment:32 Changed 9 years ago by Douglas Hays

(In [23076]) Refs #11488. Proxy commit for ksv (CCLA). Added robot test Tree_v1.html.

Changed 9 years ago by Katie Vance

Attachment: Instantiate.patch added

robot test will have failures due to #11906

comment:33 Changed 9 years ago by Douglas Hays

(In [23131]) Refs #11488. Proxy commit for ksv (CCLA). Added robot test Instantiate.html

Changed 9 years ago by Katie Vance

Attachment: CrossWindow.patch added

robot test for test_CrossWindow.html

Changed 9 years ago by Katie Vance

Attachment: Bidi.patch added

robot test for test_Bidi.html

Changed 9 years ago by Katie Vance

Attachment: nls_utf8.html added

automated test

Changed 9 years ago by Katie Vance

Attachment: nls_sjis.html added

inline automated test for nls_sjis.html

Changed 9 years ago by Katie Vance

Attachment: nls_8859-2.html added

inline automated test for nls_8859-2.html

Changed 9 years ago by Katie Vance

Attachment: module.js added

comment:34 Changed 9 years ago by Douglas Hays

(In [23145]) Refs #11488. Proxy commit for ksv (CCLA). Add an automated CrossWindow?.html robot test.

comment:35 Changed 9 years ago by Douglas Hays

(In [23146]) Refs #11488. Proxy commit for ksv (CCLA). Add an automated Bidi.html robot test.

comment:36 Changed 9 years ago by Douglas Hays

(In [23147]) Refs #11488. Proxy commit for ksv (CCLA). Add automated nls/Editor tests.

comment:37 Changed 9 years ago by Katie Vance

The only test left to automate is test_bgIframe.html. I haven't written the test yet because I'm blocked by ticket #11822.

Changed 9 years ago by Katie Vance

Attachment: test.pdf added

PDF file needed for BgIframe?.patch

comment:38 Changed 9 years ago by Katie Vance

BgIframe?.patch is only set to run on IE7 & 8. All other browsers are still blocked by ticket #11822. See that ticket for specific details.

comment:39 Changed 9 years ago by bill

I just checked in [23177] which should fix IE6. (The IE6 problem was unrelated to #11822.)

comment:40 Changed 9 years ago by Douglas Hays

BgIframe?.patch needs more work. On my IE6 XP box with java 1.6.0_20-b02, the test does not load the applet and just hangs. If I remove the programmatic applet and restore the markup applet, it runs with 0 errors.

comment:41 Changed 9 years ago by bill

(In [23187]) Avoid intermittent failures due to race condition where both the robot test and the client HTML file had delays of 4000ms. Refs #11488.

comment:42 Changed 9 years ago by bill

Another missing robot test is for CheckBox/RadioButton, see #10340.

comment:43 Changed 9 years ago by bill

(In [23277]) Dijit has extensive ContentPane tests, including tests for set("content", ...) and set("href", ...); it doesn't need a special test for programmatic ContentPane creation, certainly not a robot test. This test was probably added for documentation reasons but now we have that on the doc site. Refs #11488.

comment:44 Changed 9 years ago by bill

(In [23278]) Rewrite LayoutContainer test.

The main thing to check is that LayoutContainer lays out it's children correctly (in top/bottom/left/right/center alignment). This doesn't require robot.

The other thing to test is tab order, which we usually test via robot keyboard commands, but instead I implemented some test code to search for tabbable nodes programatically.

Refs #11488 !strict.

Changed 9 years ago by Katie Vance

Attachment: BgIframe.patch added

Changed 9 years ago by haysmark

Attachment: DOHRobot.jar added

Robot jar to fix issues with applets that steal focus.

Changed 9 years ago by haysmark

Attachment: 11488.patch added

Refs #11488. Addresses issues with applets stealing focus.

comment:45 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [23281]) Fixes #11488. Proxy commit for ksv (IBM, CCLA). Add automated bgiframe test. Tweak robot so that 2 applets can exist on the same page in linux.

comment:46 Changed 9 years ago by bill

(In [23285]) Don't use robot for testing API's, plain DOH is better. Refs #11488.

comment:47 Changed 9 years ago by bill

(In [23286]) Don't use robot for TabContainer remote loading, plain DOH is simpler. Refs #11488.

comment:48 Changed 9 years ago by bill

(In [23293]) Intermediate checkin to not use robot for !!test_TabContainer_prog.html tests, refs #11488. Will merge these tests into TabContainer.html test file in next checkin.

comment:49 Changed 9 years ago by bill

(In [23294]) Merge non-duplicate !TabContainer_prog.html tests into TabContainer.html, refs #11488.

comment:50 Changed 9 years ago by bill

(In [23316]) fixes for [23286], refs #11488.

comment:51 Changed 9 years ago by bill

(In [23344]) Fix custom icon path, refs #11488 / [23016].

comment:52 Changed 9 years ago by bill

(In [23449]) Get test running on safari. Stop using dojoattachpoint/dojoattachevent to locate nodes since it wasn't working on safari, and also since those attributes/properties may not be set on instantiated templates in the future. Refs #11488.

comment:53 Changed 9 years ago by bill

(In [23466]) Fix typo, refs #11488.

comment:54 Changed 9 years ago by bill

(In [23484]) Use persist=false flag on Tree rather than manually trying to set TreeNodes to a consistent state. The code to set TreeNodes to a consistent state was incomplete; it didn't adjust grandchildren, and whenever the test was run without clearing the cache, Mexico started out open, causing failures.

Also switching this test to old parser style of dojoType since the test is designed to test backwards compatibility.

Refs #11488.

comment:55 Changed 8 years ago by bill

Summary: SimpleTextArea: robot test[meta] missing dijit DOH tests

comment:56 Changed 8 years ago by bill

(In [24450]) Make !StackContainer_mouse.html test non-robot, and fix errors, such as calling isHidden()/isVisible() but not checking return value. Refs #11488.

comment:57 Changed 8 years ago by bill

In [27121]:

add comments so it's clear which assert failed, refs #11488

comment:58 Changed 7 years ago by bill

In [28531]:

fix funny test names, this is a test for TabIndent not ToggleDir, refs #11488

comment:59 Changed 7 years ago by bill

In [29984]:

increase timeout, refs #11488.

comment:60 Changed 6 years ago by bill

In [30952]:

Prevent spurious test failure. Tab 5 with inner tab 1 selected is the same height or near the same height as Tab 4 with inner tab 2 selected... so don't test for a height difference. Plus which it's silly to test the same behavior 8 times. Refs #11488.

comment:61 Changed 6 years ago by bill

In [31417]:

fix the text of all the hints, refs #11488

Note: See TracTickets for help on using tickets.