Opened 11 years ago
Closed 5 years ago
#11487 closed defect (patchwelcome)
Unwanted padding in Dnd Avatar from a tree
Reported by: | Eric Pasquier | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | DnD | Version: | 1.5 |
Keywords: | dnd avatar tree | Cc: | |
Blocked By: | Blocking: |
Description
When dragging from a tree, the avatar is created from the current node. When using a tree, the current node have a large padding-left value depending on tree level. This padding value should be reset when creating the Dnd Avatar to avoid a huge blank area on the left.
Suggested change :
dojo.dnd.Avatar (file dojo/dnd/Avatar.js) // methods construct: function(){ - - - node.id = ""; dojo.style(node, "padding", "0"); //<-- added tr = dojo.create("tr", null, b); td = dojo.create("td", null, tr); td.appendChild(node); - - -
A change also need to be done in themes to display avatars correctly in some situations:
Common.css (files dijit/themes/xxxxx/Common.js) xxxxx=soria,tundra,... .soria table.dojoDndAvatar {- - -; width:auto;} .soria .dojoDndAvatar img { display: inline; }
Change History (11)
comment:1 Changed 11 years ago by
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
Milestone: | tbd → 1.6 |
---|---|
Status: | new → assigned |
comment:4 follow-up: 7 Changed 10 years ago by
Hi Eugene, Is it possible to have a feedback for this problem ? Thanks, Eric
comment:5 Changed 10 years ago by
Milestone: | 1.6 → 1.7 |
---|
comment:6 Changed 10 years ago by
Milestone: | 1.7 → 1.8 |
---|
comment:7 Changed 9 years ago by
Replying to Eric P:
Is it possible to have a feedback for this problem ?
I plan to test and commit before 1.8.
comment:8 Changed 9 years ago by
Milestone: | 1.8 → 2.0 |
---|
1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.
comment:9 Changed 9 years ago by
Milestone: | 2.0 → 1.8 |
---|---|
Summary: | Enhancement in Dnd Avatar from a tree → Unwanted padding in Dnd Avatar from a tree |
Type: | enhancement → defect |
This isn't really an enhancement, it's just a bug fix to how avatars look.
PS: if there was a way for each source to specify it's own avatar, then Tree could solve this problem itself... but AFAICT the only way to override the avatar method is to override it for every Source.
comment:10 Changed 9 years ago by
Milestone: | 1.8 → 2.0 |
---|
1.8 has been tagged; moving all outstanding tickets to next major release milestone.
comment:11 Changed 5 years ago by
Milestone: | 2.0 → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | assigned → closed |
Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.
Do you need more information ? Eric.