Unwanted padding in Dnd Avatar from a tree

[Eric Pasquier]

When dragging from a tree, the avatar is created from the current node. When using a tree, the current node have a large padding-left value depending on tree level. This padding value should be reset when creating the Dnd Avatar to avoid a huge blank area on the left.

Suggested change :

dojo.dnd.Avatar (file dojo/dnd/Avatar.js)
// methods
construct: function(){
- - -
node.id = "";
dojo.style(node, "padding", "0"); //<-- added
tr = dojo.create("tr", null, b);
td = dojo.create("td", null, tr);
td.appendChild(node);
- - -

A change also need to be done in themes to display avatars correctly in some situations:

Common.css (files dijit/themes/xxxxx/Common.js)  xxxxx=soria,tundra,...
.soria table.dojoDndAvatar {- - -; width:auto;}
.soria .dojoDndAvatar img { display: inline; }

[Eric Pasquier]

Do you need more information ? Eric.

[Eric Pasquier]

Please find below a drawing with the explanation of the problem :

If you do not have time to correct it, can you please tell me the procedure to make the correction for the next release (I already signed the CLA) ?

Thanks, Eric.

[Eric Pasquier]

Hi Eugene, Is it possible to have a feedback for this problem ? Thanks, Eric

[Eugene Lazutkin]

Replying to Eric P:

Is it possible to have a feedback for this problem ?

I plan to test and commit before 1.8.

[Colin Snover]

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

[bill]

This isn't really an enhancement, it's just a bug fix to how avatars look.

PS: if there was a way for each source to specify it's own avatar, then Tree could solve this problem itself... but AFAICT the only way to override the avatar method is to override it for every Source.

[Colin Snover]

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

[dylan]

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.