#11485 closed defect (fixed)
TimeTextBox: strange sorting on filtered results
Reported by: | bill | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit - Form | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Attachments (1)
Change History (10)
Changed 10 years ago by
comment:1 Changed 10 years ago by
TimeTextBox? always loops through times, so after 13:45 would come 13:00. Hovering over the arrow will make it loop. Do you want the looping to stop (and the arrows to be removed as well)?
comment:2 Changed 10 years ago by
I guess the question is why it starts at 13:30, rather than 13:00.
comment:3 Changed 10 years ago by
(In [22580]) Various [stop gap] fixes to TimeTextBox, although still wondering about full rewrite as per #7631, or replacing custom scrolling with native scrollbar like ComboBox has. Fixes include:
- limit drop down to 10 entries so that (in the majority of cases) it won't overlap the <input> box (fixes #8387)
- same as ComboBox, make typing automatically open the dropdown, and once the user has started typing or backspacing the dropdown list is filtered by what's in the <input> (fixes #11486)
- fix recently introduced problem (with _HasDropDown conversion of _DateTimeTextBox, refs #6416) where drop down becomes detached from <input> when it appears above the input and then user types text to further filter the values shown
- add more tests for TimeTextBox; they previous tests were very sparse; tests include check of current filtering sort order (refs #11485)
!strict as usual.
comment:4 Changed 10 years ago by
Milestone: | tbd → 1.6 |
---|
bill, I couldn't recreate this after [22580].
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Full-rewrite aside, please reopen if there's still a scenario that does not filter correctly.
comment:6 Changed 10 years ago by
The issue was with sorting, not filtering. AFAIK filtering is working fine.
What's the expected sorting behavior of the current code? In the "12 Hour Time" example in test_TimeTextBox.html, when I enter "4" in the <input> the drop down opens centered at 4AM, but when I enter 5 it centers on 5PM. This seems random. Your results may vary depending on your timezone or the time of day when you run the test. (I ran my test in Japanese timezone at 12:25PM, on FF3.6/win)
comment:7 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:8 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:9 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
screenshot