Opened 9 years ago

Closed 9 years ago

#11483 closed defect (fixed)

Calendar: ctrl-page-up/down doesn't work on FF/mac

Reported by: bill Owned by: Adam Peller
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description

On IE, Safari, and even FF on windows, ctrl-page-up/ctrl-page-down switch the calendar's year. However, on FF/mac it switches to a different browser tab. So there's no way to keyboard to the next/prev year except by advancing the month 12 times.

I tried altering Calendar.js to also respond to the alt-page-up combination. That works, but on my mac it beeps every time too, making it unpleasant to use. Note though that I've got a notebook so I'm actually pressing fn-alt-down-arrow.

Not sure if there's any fix for this or not. But I'm adding tests to form/robot/DateTextBox.html now so I'm at least filing the ticket for reference.

Change History (5)

comment:1 Changed 9 years ago by bill

(In [22561]) Keyboard tests for DateTextBox, working around the known issue #11483, #11484, and the lack of key repeat support. Should add tests for navigation across disabled dates, and for key repeat, after those features are working. Refs #6430, #9918, #11483, #11484.

comment:2 Changed 9 years ago by bill

Note: after fixing this, remove the following code from DateTextBox.html:

if(dojo.isMac && dojo.isFF){
	// doesn't work on mac/FF, see #11483
	doh.robot.sequence(d.getTestErrback(function(){
		calendar.set("value", new Date(2007, 5, 18));
	}), 500);

comment:3 Changed 9 years ago by Adam Peller

Cc: Becky Gibson added

comment:4 Changed 9 years ago by bill

Milestone: tbd1.6

Somehow this is working for me, with my pending checkin for #10001.

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [22665]) Calendar: separate focus and selection handling, so that (like ColorPalette and Tree), arrow keys navigate and ENTER/SPACE selects the date (fixes #10001 !strict). This allows navigation across disabled dates (refs #6430, fixes #11484), and completes keyboard support for DateTextBox, although it still needs screen reader work (refs #9918).

Also seems to have fixed the ctrl-page-up/down problem on FF/mac (fixes #11483).

Also merged in Calendar.set("value", ..., priorityChange) support from neonstalwart (fixes #11331), thanks!

Note: See TracTickets for help on using tickets.