Opened 10 years ago
Closed 5 years ago
#11479 closed defect (patchwelcome)
Gray Out Check Box and Radio Button Labels
Reported by: | David Schwartz | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | Dijit - LnF | Version: | 1.5 |
Keywords: | ibm disable checkbox | Cc: | |
Blocked By: | Blocking: |
Description
When a check box or radio button is inactive, currently the interactive element is grayed but the label remains black. This is a subtle change that is not always readily apparent to users and is inconsistent with these elements in other environments. Further, the user should perceive the label as part of the widget and so the label should behave similar to the interactive element.
Check box and radio button labels should be grayed whenever the widget itself is disabled.
Attachments (3)
Change History (7)
comment:1 Changed 10 years ago by
Milestone: | 1.5.1 → 1.6 |
---|
Changed 10 years ago by
Attachment: | grayedCheckbox.png added |
---|
windows dialog w/grayed checkbox label
Changed 10 years ago by
Attachment: | grayedFileInput.png added |
---|
windows dialog w/grayed label for file input
Changed 10 years ago by
Attachment: | grayedColorPicker.png added |
---|
windows dialog w/grayed label for color picker
comment:2 Changed 10 years ago by
[11973] finds the labels associated with ComboBox/FilteringSelect widgets, and [14240] did the same for Slider, so I guess there's a precedent to finding labels associated with form widgets. OTOH a typical page will have many more plain TextBox (or ValidationTextBox) widgets than ComboBox/Slider widgets.
comment:3 Changed 10 years ago by
Milestone: | 1.6 → future |
---|
comment:4 Changed 5 years ago by
Milestone: | future → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.
This isn't suitable for a patch release, maybe for 1.6 is OK. But I'm skeptical whether the performance would be acceptable if we need to query for the label of every disabled CheckBox/RadioButton on page startup. Maybe there's something to be done with a wrapper widget (a fieldset widget) to limit the scope that we search for the label.
Also, what about the labels associated with other disabled widgets, like a disabled ComboBox?