Opened 4 years ago

Closed 3 years ago

#11476 closed defect (invalid)

[regression] dojox.layout.ToggleSplitter doesn't update position on double click

Reported by: jrasmuss Owned by: sfoster
Priority: high Milestone: tbd
Component: DojoX Layout Version: 1.5
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by bill)

After upgrading to Dojo 1.5.0, dojox.layout.ToggleSplitter no longer handles double-clicks properly. It seems to have been broken since May 29th. Double-clicking on a splitter does set the visibility of the relevant ContentPane properly and does update the splitter icon, but the divider location does not change. If a second splitter in the same container is double-clicked, the first moves to the proper location, the second does not. A screenshot is attached.

Works: http://archive.dojotoolkit.org/dojo-2010-05-28/dojotoolkit/dojox/layout/tests/test_ToggleSplitter.html
Broken: http://archive.dojotoolkit.org/dojo-2010-05-29/dojotoolkit/dojox/layout/tests/test_ToggleSplitter.html

This problem is consistent across Firefox 3.6.7, IE 8, etc. Changes to BorderContainer.js appear to be to blame: http://mail.dojotoolkit.org/pipermail/dojo-checkins/2010-May/075208.html

Attachments (1)

ToggleSplitterBroken.png (14.7 KB) - added by jrasmuss 4 years ago.
Screenshot showing problem

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by jrasmuss

Screenshot showing problem

comment:1 Changed 4 years ago by davliu

Hi,

I have the same issue which hindered me to upgrade my application to use dojo 1.5

comment:2 Changed 4 years ago by bill

  • Component changed from General to Dojox
  • Description modified (diff)
  • Owner changed from anonymous to peller
  • Summary changed from dojox.layout.ToggleSplitter doesn't update position on double click to [regression] dojox.layout.ToggleSplitter doesn't update position on double click

comment:3 Changed 4 years ago by bill

  • Component changed from Dojox to DojoX Layout
  • Owner peller deleted

comment:4 Changed 4 years ago by bill

  • Owner set to sfoster

It should be changed to pass in a width (or height for top/bottom panes) to this.container._layoutChildren, ex:

To close the pane:

this.container._layoutChildren(this.region, 0)

To open the pane:

this.container._layoutChildren(this.region, 300)

However, ToggleSplitter has lots of code in _handleOnChange() and _getStyleProps() for dealing with style, and I don't know what it's for. It seems unnecessary to me, seems like all you should need is that one _layoutChildren() call.

comment:5 Changed 3 years ago by sfoster

  • Resolution set to invalid
  • Status changed from new to closed

Work on #12689 to change the ToggleSplitter to a 3-state open/collapsed/closed model makes this issue invalid. I think its much improved, but please re-open or file a new ticket if what's in trunk doesn't work for you, or leaves other issues not addressed.

Note: See TracTickets for help on using tickets.