Opened 12 years ago
Closed 11 years ago
#11476 closed defect (invalid)
[regression] dojox.layout.ToggleSplitter doesn't update position on double click
Reported by: | jrasmuss | Owned by: | Sam Foster |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | DojoX Layout | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
After upgrading to Dojo 1.5.0, dojox.layout.ToggleSplitter no longer handles double-clicks properly. It seems to have been broken since May 29th. Double-clicking on a splitter does set the visibility of the relevant ContentPane properly and does update the splitter icon, but the divider location does not change. If a second splitter in the same container is double-clicked, the first moves to the proper location, the second does not. A screenshot is attached.
Works: http://archive.dojotoolkit.org/dojo-2010-05-28/dojotoolkit/dojox/layout/tests/test_ToggleSplitter.html Broken: http://archive.dojotoolkit.org/dojo-2010-05-29/dojotoolkit/dojox/layout/tests/test_ToggleSplitter.html
This problem is consistent across Firefox 3.6.7, IE 8, etc. Changes to BorderContainer.js appear to be to blame: http://mail.dojotoolkit.org/pipermail/dojo-checkins/2010-May/075208.html
Attachments (1)
Change History (6)
Changed 12 years ago by
Attachment: | ToggleSplitterBroken.png added |
---|
comment:1 Changed 12 years ago by
Hi,
I have the same issue which hindered me to upgrade my application to use dojo 1.5
comment:2 Changed 12 years ago by
Component: | General → Dojox |
---|---|
Description: | modified (diff) |
Owner: | changed from anonymous to Adam Peller |
Summary: | dojox.layout.ToggleSplitter doesn't update position on double click → [regression] dojox.layout.ToggleSplitter doesn't update position on double click |
comment:3 Changed 12 years ago by
Component: | Dojox → DojoX Layout |
---|---|
Owner: | Adam Peller deleted |
comment:4 Changed 12 years ago by
Owner: | set to Sam Foster |
---|
It should be changed to pass in a width (or height for top/bottom panes) to this.container._layoutChildren, ex:
To close the pane:
this.container._layoutChildren(this.region, 0)
To open the pane:
this.container._layoutChildren(this.region, 300)
However, ToggleSplitter has lots of code in _handleOnChange() and _getStyleProps() for dealing with style, and I don't know what it's for. It seems unnecessary to me, seems like all you should need is that one _layoutChildren() call.
comment:5 Changed 11 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Work on #12689 to change the ToggleSplitter? to a 3-state open/collapsed/closed model makes this issue invalid. I think its much improved, but please re-open or file a new ticket if what's in trunk doesn't work for you, or leaves other issues not addressed.
Screenshot showing problem