Unnecessary code in AccordionContainer?

[xMartin]

Line 179-185 in dijit/layout/AccordionContainer.js:

		_transition: function(/*dijit._Widget?*/newWidget, /*dijit._Widget?*/oldWidget, /*Boolean*/ animate){
			// Overrides StackContainer._transition() to provide sliding of title bars etc.

//TODO: should be able to replace this with calls to slideIn/slideOut
			if(this._inTransition){ return; }
			var animations = [];
			var paneHeight = this._verticalSpace;

Seems as if the variable paneHeight in the last line is never used and thus unnecessary and confusing. Or am I missing something?

[bill]

Thanks for the catch, I'll remove the line.

[bill]

(In [22541]) remove unused code, fixes #11472 !strict

[xMartin]

So it appears that there may be more unnecessary lines here.

Please check line 198-199:

dojo.addClass(newContents, "dijitVisible");
dojo.removeClass(newContents, "dijitHidden");

Same addClass/removeClass statements are already called in _showChild() which is invoked a few lines above.

[bill]

Good catch, plus looks like we can reduce further by calling _hideChild() too (with the added benefit that it sets child.selected to false (counteracting what _showChild() did).

[bill]

(In [22618]) Further AccordionContainer code reductions, fixes #11472 again, !strict.