Opened 9 years ago

Closed 9 years ago

#11467 closed defect (fixed)

Buttons overlap scroll bar in dojox.widget.Wizard

Reported by: Katie Vance Owned by: dante
Priority: high Milestone: 1.6
Component: DojoX Widgets Version: 1.5
Keywords: Cc: Katie Vance
Blocked By: Blocking:

Description

Whenever the wizard pane content gets too large for the size of the pane, the scroll bars (horizontal or vertical) will overlap the wizard navigation buttons. The user can add a margin-bottom css attribute to all of their wizard panes to avoid the issue, but doing so is not obvious to the user. Instead the widget should be able to automatically account for this issue.

Attached is a patch to fix this issue as well as a new test case to test the problem.

The fix will determine the height of the buttons and use it as the margin-bottom css attribute to the wizardPane to make room for the buttons. If the user has already worked around this issue by manually setting the margin-bottom themselves, then the wizard does not modify the user set css value.

Attachments (2)

Wizard.js (6.6 KB) - added by Katie Vance 9 years ago.
Patch for wizard.js
test_Wizard.html (7.4 KB) - added by Katie Vance 9 years ago.
New test case for the buttons overlapping the scroll bar

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Katie Vance

Attachment: Wizard.js added

Patch for wizard.js

Changed 9 years ago by Katie Vance

Attachment: test_Wizard.html added

New test case for the buttons overlapping the scroll bar

comment:1 Changed 9 years ago by Adam Peller

If possible, please use patch files (svn diff) Also, please confirm that you're covered by a CLA or CCLA by a particular company.

comment:2 Changed 9 years ago by dante

Milestone: tbd1.6
Status: newassigned

comment:3 Changed 9 years ago by dante

looked at the patch. it does a lot of expensive coords() calls to determine the maximum height of all the buttons. Started down the path of just calculating the buttonBar height once and using that, then realized it's always about 38px, so just put that rule in CSS.

.dojoxWizardContainer > * { margin-bottom:38px; }

All first-children are told to avoid the buttons. this causes scrollbars to appear in the expected position and seemingly has no effect when the container doesn't overflow.

comment:4 Changed 9 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [22724]) fixes #11467 - add default css margins, add tests. some whitespace

Note: See TracTickets for help on using tickets.