Opened 10 years ago

Closed 4 years ago

#11452 closed defect (fixed)

[meta] remove attr() as a getter setter in dojox

Reported by: dante Owned by:
Priority: high Milestone: 1.11
Component: Dojox Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

There are lots of things still calling this.attr() as a getter/setter. use this ticket to track any of those you spot and fix.

Attachments (3)

form.get.set.patch​ (24.0 KB) - added by dante 10 years ago.
dojox.form, some style, tiny reductions, all attr -> get/set
grid._Scroller.patch​ (852 bytes) - added by Kenneth G. Franqueiro 10 years ago.
Patch for two leftover grid attr calls in _Scroller. Warnings visible in test_data_grid_autoheight.html
layout.patch​ (2.2 KB) - added by Kenneth G. Franqueiro 9 years ago.
Patch for leftovers in dojox.layout

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by dante

Attachment: form.get.set.patch​ added

dojox.form, some style, tiny reductions, all attr -> get/set

comment:1 Changed 10 years ago by dante

(In [22517]) refs #11452 - lots of attr changes. \!strict

Changed 10 years ago by Kenneth G. Franqueiro

Attachment: grid._Scroller.patch​ added

Patch for two leftover grid attr calls in _Scroller. Warnings visible in test_data_grid_autoheight.html

Changed 9 years ago by Kenneth G. Franqueiro

Attachment: layout.patch​ added

Patch for leftovers in dojox.layout

comment:2 Changed 9 years ago by Kenneth G. Franqueiro

(In [23579]) refs #11452 - updating old attr calls in dojox.layout.

comment:3 Changed 9 years ago by evan

"grid._Scroller.patch" is done - included in [23591] for #11986

comment:4 Changed 9 years ago by bill

Milestone: 1.6 → future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:5 Changed 9 years ago by Chris Mitchell

Owner: anonymous deleted

comment:6 Changed 4 years ago by dylan

Milestone: future → 1.11
Resolution: → fixed
Status: new → closed

Patches that were added were landed, no further activity in 5 years, so closing as fixed.

Note: See TracTickets for help on using tickets.