Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11441 closed defect (fixed)

claro: slight fit and finish oddness with tab label

Reported by: dante Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit - LnF Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

Such a terribly small nit with such a lovely theme. The node which receives focus has natural paddings, putting the outline border inside the tab label, but around the text. It is probably 3px off-center. When focusing a tab label, the left edge of the focus border is 2px from the text, which is 5px from the edge of the tab button. On the right side, those 2px are absent, but the label remains centered (which looks perfect).

When you do nested="true", the problem becomes more apparent. The focusNode is assigned a background, and the actual label looks uncentered because of the same 3px difference visible in plain tab labels.

Change History (7)

comment:2 Changed 9 years ago by dante

Milestone: tbdfuture

comment:3 Changed 9 years ago by bill

Milestone: future1.6
Owner: changed from Julie Santilli to bill
Status: newassigned

This has changed since you filed the ticket but there are still some spacing irregularities, which I have a fix for.

comment:4 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [23629]) Fix inconsistent tab height when browser font size is small and some (but not all) of the tabs have a close icon. Height was consistent on soria/nihilo (see [17433]) but not on claro/tundra.

Also fixes extra padding on the left of tabs that was occurring due to a 1x1 blank image for the icon even when there was no icon specified. Have to make it display:none in that case since even a 0x0 <img> causes extra padding around the node, at least on FF.

Not sure if the placement of the close icon is exactly where claro wants it or not, could tweak that.

Fixes #11441, refs #9123 !strict.

comment:5 Changed 9 years ago by bill

(In [23630]) Patch from Jason to consolidate border-radius CSS for nested tab buttons to one place. Refs #11441.

comment:6 Changed 9 years ago by bill

(In [23631]) Fix display of tab icons on IE6. Also fixed missing border on bottom of nested tab buttons.

Refs #11441 !strict.

comment:7 Changed 9 years ago by bill

(In [23632]) Make similar fixes for bottom/left/right tabs like I did for top tabs. Also more padding fixes. Refs #11441 !strict.

Note: See TracTickets for help on using tickets.