Opened 6 years ago

Last modified 7 months ago

#11435 assigned defect

dojox.validate.regexp.url is too specific with fragment identifiers

Reported by: markwubben Owned by: dylan
Priority: high Milestone: 1.12
Component: Dojox Version: 1.5.0rc1
Keywords: Cc: doughays, peller, dante
Blocked by: Blocking:

Description

The fragment identifier is validated as such:

#[A-Za-z][\\w.:-]*

These days any character is used in the fragment identifier, for example the #! combo supported by Google. Also, URLs simply ending in # are treated as being invalid.

Can we change it to this instead?

#.*

Change History (3)

comment:1 Changed 6 years ago by peller

That's probably code carried over from Dojo 0.4, so feel free to improve. Is there anything on this in the RFC we can use that's better than ".*"?

comment:2 Changed 7 months ago by dylan

  • Cc doughays peller dante added; doughays peller dante removed
  • Milestone changed from tbd to 1.11
  • Owner changed from peller to dylan
  • Status changed from new to assigned

comment:3 Changed 7 months ago by dylan

  • Milestone changed from 1.11 to 1.12

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

Note: See TracTickets for help on using tickets.