Opened 9 years ago

Last modified 18 months ago

#11435 assigned defect

dojox.validate.regexp.url is too specific with fragment identifiers

Reported by: Mark Wubben Owned by: dylan
Priority: high Milestone: 1.14
Component: Dojox Version: 1.5.0rc1
Keywords: Cc: Douglas Hays, Adam Peller, dante
Blocked By: Blocking:

Description

The fragment identifier is validated as such:

#[A-Za-z][\\w.:-]*

These days any character is used in the fragment identifier, for example the #! combo supported by Google. Also, URLs simply ending in # are treated as being invalid.

Can we change it to this instead?

#.*

Change History (5)

comment:1 Changed 9 years ago by Adam Peller

That's probably code carried over from Dojo 0.4, so feel free to improve. Is there anything on this in the RFC we can use that's better than ".*"?

comment:2 Changed 3 years ago by dylan

Cc: Douglas Hays Adam Peller dante added; doughays peller dante removed
Milestone: tbd1.11
Owner: changed from Adam Peller to dylan
Status: newassigned

comment:3 Changed 3 years ago by dylan

Milestone: 1.111.12

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

comment:4 Changed 2 years ago by dylan

Milestone: 1.121.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:5 Changed 18 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.