Incremental Improvements to svg2gfx.xsl

[Feneric]

I have attached a patch to svg2gfx.xsl that removes some of the unnecessary trailing commas left by the conversion. It does not (yet) remove all of them, just the simple cases with elements.

[Feneric]

patch for svg2gfx.xsl

[Eugene Lazutkin]

For some reason the patch file is 0 bytes. Please send it to me directly (or the whole file --- whatever is easier).

[bill]

I think the patch file is valid, it's just that it doesn't show up in the formatted view... that's a problem sometimes with [our] trac instance. If you download the patch in the raw format (original format link after following the above link), I think it will work.

[Eugene Lazutkin]

Replying to bill:

If you download the patch in the raw format (original format link after following the above link), I think it will work.

Did you try to download it? Could you?

[bill]

Oops, you are right, it downloads as zero size. Nevermind.

[Eugene Lazutkin]

The original file.

[Eugene Lazutkin]

(In [22471]) gfx: replaced the resource XSL file to reduce number of stray commas, thx Eric W. Brown!, !strict, fixes #11427.

[John Locke]

This patch generates an invalid JSON file, if there is a transform on a group.

Starting around line 792, the test for last has the wrong context -- if this is the last child of the svg element, and it is a <g> element, and the <g> has a transform attribute, the comma gets omitted after the "children" object, before the "transform" item.

Also, there are still a lot of stray trailing commas that get generated by this xslt file, which break IE7. My temporary fix was to add the comma back to this item, and then use sed to strip out all the stray commas immediately before } or ].

[tcrass]

Hi,

just encountered another incarnation of the "over-shooting comma removal" issue mentioned by freelock two postings above -- the attached file's processing output is invalid because in the generated JSON, the first (and only) SVG path's stroke attribute gets appended to the (correctly transformed) fill attribute, but *without* a comma to separate the two of them.

[tcrass]

When transformed, results in missing comma between the path's fill and style attribute

[dylan]

@Feneric, do you care to revisit this (I know it's been eons), to address some of the regressions that were introduced?

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.