Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#11386 closed defect (fixed)

[patch]the datagrid's editable cell can't save when click on area outside the grid.

Reported by: dojocn Owned by: Evan
Priority: blocker Milestone: 1.9
Component: DojoX Grid Version: 1.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

the datagrid's editable cell can't save when click on area outside the grid. other details: 1, clicking other cells can save the edited cell's data; 2, clicking the grid's header will sort the grid but the editable cell keep editing status.

the link for the demo of this bug : http://bugs.dojotoolkit.org/browser/dojox/trunk/grid/tests/test_edit_canEdit.html

Attachments (1)

datagrid-#11386.patch (530 bytes) - added by evan 9 years ago.
Issue fixed by auto applying edit changes

Download all attachments as: .zip

Change History (15)

comment:1 Changed 9 years ago by bill

Owner: changed from bryanforbes to Bryan Forbes

comment:2 Changed 9 years ago by evan

This patch also fixed a duplicate issue #7779

comment:3 Changed 9 years ago by Adam Peller

Owner: changed from Bryan Forbes to evan

push() and comment are unnecessary. Just declare

this.connections = [ dojo.connect(this.grid, 'onBlur', this, 'apply') ];

svn will remember the changeset and associate it with the ticket number.

Changed 9 years ago by evan

Attachment: datagrid-#11386.patch added

Issue fixed by auto applying edit changes

comment:4 Changed 9 years ago by evan

Thanks, Adam, I updated the patch.

comment:5 Changed 9 years ago by evan

Summary: the datagrid's editable cell can't save when click on area outside the grid.[patch]the datagrid's editable cell can't save when click on area outside the grid.

comment:6 Changed 9 years ago by Evan

Resolution: fixed
Status: newclosed

(In [23621]) Fixes #11386 by applying changes in editing when grid gets blurred

comment:7 Changed 9 years ago by evan

Milestone: tbd1.6

comment:8 Changed 9 years ago by evan

(In [23890]) Fix regression caused by [23621] - shouldn't be applied for IE6/7, refs #11386

comment:9 Changed 9 years ago by evan

(In [23903]) "Applying changes in editing when grid gets blurred" - this should be only effective for !IE, refs #11386

comment:10 Changed 9 years ago by evan

Milestone: 1.6future
Resolution: fixed
Status: closedreopened

Reopening, the issue still exits in IE, [23621] can only be applied for none IE.

Applying [23621] in IE will cause not be able to editing cells.

We can use grid.edit.apply() as a temporary workaround for applying changes when needed.

comment:11 Changed 8 years ago by Evan

Owner: changed from evan to Evan
Status: reopenednew

comment:12 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:13 Changed 7 years ago by Evan

Resolution: fixed
Status: newclosed

In [30134]:

Fixes #11386, the previous fix - "auto apply the change when grid is blurred" is now working well in IE7+

comment:14 Changed 7 years ago by Evan

Milestone: future1.9
Note: See TracTickets for help on using tickets.